Fix regression in selecting default RuntimeIdentifier #3543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsplaisted
force-pushed
the
3495-automatic-x86
branch
from
e29ed33 to
fac52f3
Compare
nguerrera
approved these changes
Aug 16, 2019
nguerrera
reviewed
Aug 17, 2019
| @@ -305,6 +308,7 @@ private void ReadItemGroups() | |||
| FrameworkAssemblies = reader.ReadItemGroup(); | |||
| FrameworkReferences = reader.ReadItemGroup(); | |||
| NativeLibraries = reader.ReadItemGroup(); | |||
| PackageDependencies = reader.ReadItemGroup(); | |||
There was a problem hiding this comment.
@nguerrera I've bumped it, can you re-approve?
nguerrera
suggested changes
Aug 17, 2019
dsplaisted
force-pushed
the
3495-automatic-x86
branch
from
460e0b1 to
3bef5b2
Compare
nguerrera
approved these changes
Aug 19, 2019
dsplaisted
pushed a commit
to dsplaisted/sdk
that referenced
this pull request
Feb 19, 2020
….1 (dotnet#3543) - Microsoft.DotNet.Cli.Runtime - 3.1.100-preview3.19562.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed change in behavior (regression) that was introduced when we started including the RuntimeIdentifier graph in the SDK and passing it to NuGet.
Customer Impact
The change in behavior had to do with the automatic selection of the PlatformTarget. In specific cases, the PlatformTarget would be set to x86, where it would have previously been set to AnyCPU. This is because previously you had to have a (transitive) dependency on the Microsoft.NETCore.Platforms package to get the RuntimeIdentifier graph, and without it, you wouldn't get assets that didn't exactly match the default RuntimeIdentifier (win7-x86). Since no native assets were found, the PlatformTarget defaulted to AnyCPU, even though if the RuntimeGraph had been available there would have been native assets.
Roslyn ran into this, their apps switched to x86 unintentionally. We are not sure how many other customers would be impacted, as the combination of factors necessary to see the behavior change is somewhat of an edge case.
Regression?
Yes, regressed with #3406
Risk
Low
Fixes #3495
I thought of a "clever" way to fix this regression. We revert to the AnyCPU PlatformTarget if:
This should match the PlatformTarget which SDKs prior to the 3.0 SDK would have used.