When Hot Reload change fails to apply in the browser send full error … #33471
Conversation
dotnet-issue-labeler
bot
added
Area-AspNetCore
|
Thanks for your PR, @tmat. |
|
@tlmii PTAL |
| @@ -43,7 +43,8 @@ setTimeout(async function () { | |||
| const payload = JSON.parse(message.data); | |||
| const action = { | |||
| 'UpdateStaticFile': () => updateStaticFile(payload.path), | |||
| 'BlazorHotReloadDeltav1': () => applyBlazorDeltas(payload.sharedSecret, payload.deltas), | |||
| 'BlazorHotReloadDeltav1': () => applyBlazorDeltas(payload.sharedSecret, payload.deltas, false), | |||
| 'BlazorHotReloadDeltav2': () => applyBlazorDeltas(payload.sharedSecret, payload.deltas, true), | |||
There was a problem hiding this comment.
I preserved backward compat here, but I'm not sure what the versioning requirements actually here. Can this script be used across multiple versions of dotnet-watch? If not, why have version in the action name at all?
There was a problem hiding this comment.
I had a similar thought. I guess I could imagine a scenario where the injection occurs from one version of the SDK and dotnet-watch is run from another (particularly with local copies of the SDK like we have with arcade)? But it seems like you'd have to jump through some hoops to make that happen.
…message to the client so that it can be logged
tmat
force-pushed
the
SendErrorMessageFromBrowser
branch
from
30653f9 to
c77a092
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…message to the client so that it can be logged