Choose KnownILCompilerPacks based on TFM + RID #31398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now appropriate ILCompiler pack selected purely based on TFM. To relatively easy support of NativeAOT LLVM I would like that selection of ILCompiler pack happens on pair TFM + RID. That allow adding custom ILC (as in case NativeAOT LLVM) using following code in the project file (only) ``` <KnownILCompilerPack Include="Microsoft.DotNet.ILCompiler.LLVM" TargetFramework="net7.0" ILCompilerPackNamePattern="runtime.**RID**.Microsoft.DotNet.ILCompiler.LLVM" ILCompilerPackVersion="8.0.0" ILCompilerRuntimeIdentifiers="browser-wasm" /> ``` As you see it allows indication of the supported "browser-wasm" RID without disrupting other RID targets. Right now it's possible to have workaround like this ``` <KnownILCompilerPack Update="Microsoft.DotNet.ILCompiler" TargetFramework="net7.0" ILCompilerPackNamePattern="runtime.**RID**.Microsoft.DotNet.ILCompiler.LLVM" ILCompilerPackVersion="8.0.0-alpha.1.23172.3" ILCompilerRuntimeIdentifiers="browser-wasm;linux-musl-x64;linux-x64;win-x64;linux-arm;linux-arm64;linux-musl-arm;linux-musl-arm64;osx-arm64;osx-x64;win-arm;win-arm64;win-x86" /> ``` but with appearace of .NET 8 which has 2 KnownILCompilerPack entry that become problematic and implicit package referencing logic rely on item identity.
dotnet-issue-labeler
bot
added
Area-ReadyToRun
untriaged
|
can this be closed now? |
|
Technically I think that was sensible change anyway, but if that bring some complexity to SDK, I have no case for that now. |
|
I'm sure it will come up again just trying to keep things tidy at the moment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now appropriate ILCompiler pack selected purely based on TFM. To relatively easy support of NativeAOT LLVM I would like that selection of ILCompiler pack happens on pair TFM + RID.
That allow adding custom ILC (as in case NativeAOT LLVM) using following code in the project file (only)
As you see it allows indication of the supported "browser-wasm" RID without disrupting other RID targets. Right now it's possible to have workaround like this
but with appearace of .NET 8 which has 2 KnownILCompilerPack entry that become problematic and implicit package referencing logic rely on item identity.