Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GenerateLayout.targets for Microsoft.CodeAnalysis.NetAnalyzers packaging structure changes #29906

Closed
wants to merge 4 commits into from
Closed

Update GenerateLayout.targets for Microsoft.CodeAnalysis.NetAnalyzers packaging structure changes #29906

wants to merge 4 commits into from

Conversation

mavasani
Copy link
Contributor

@mavasani mavasani commented Jan 12, 2023 •
edited
Loading

React to package structure updates in dotnet/roslyn-analyzers#6325 and dotnet/roslyn-analyzers#6427 to copy props/targets/config files from the buildtransitive folder in the NuGet package

@mavasani
Update GenerateLayout.targets
031aa37 
React to package structure updates in dotnet/roslyn-analyzers#6325 and dotnet/roslyn-analyzers#6427 to generate props/targets/config files in `buildtransitive` folder
@mavasani mavasani requested a review from jmarolf January 12, 2023 10:44
@mavasani
Copy link
Contributor Author

@Youssef1313

@Youssef1313
Copy link
Member

I think this should be synchronized with NetAnalyzers version update that has the change

@mavasani
Copy link
Contributor Author

I think this should be synchronized with NetAnalyzers version update that has the change

Yes, will have to wait for dotnet/roslyn-analyzers#6427 to be merged and then get the new NetAnalyzers version update which has this fix.

mavasani
mavasani commented Jan 13, 2023
View reviewed changes
eng/Version.Details.xml Outdated Show resolved Hide resolved
@mavasani mavasani mentioned this pull request Jan 13, 2023
Merged
@mavasani
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mavasani
Copy link
Contributor Author

@nagilson for review. The build is passing fine for all but Ubuntu. I am not sure if this is a CI issue, because the file that is being complained as missing is indeed present in the package.

@mavasani
Copy link
Contributor Author

Closing in favor of #29911

@mavasani mavasani closed this Jan 16, 2023
@ViktorHofer ViktorHofer deleted the mavasani-patch-1 branch January 17, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmarolf jmarolf Awaiting requested review from jmarolf

Assignees
No one assigned
Labels
Area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mavasani @Youssef1313