[release/7.0.1xx] Fix msbuild evaluation of ApiCompat task pkg #28301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport of 0a1f5cd.
ericstj
approved these changes
Oct 3, 2022
|
Approved offline by Tactics via mail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of 0a1f5cd.
Customer Impact
Customers who reference the
Microsoft.DotNet.ApiCopmat.Taskpackage to make use of the very latest APICompat features (which aren't yet available in the SDK) will notice an msbuild evaluation error that will effectively break their build. Fixing the broken msbuild condition which recently regressed as part of e99f2b7.Testing
I verified that adding a reference to the
Microsoft.DotNet.ApiCompat.Tasknuget package doesn't result in an msbuild evaluation error anymore and that the component works as intended. Filed #28300 for adding CI protection.Risk
Very low. The msbuild evaluation is unblocked and the condition still works as expected.