[release/7.0.1xx] Update dependencies from dotnet/runtime #27803

dotnet-maestro · 2022-09-10T01:30:05Z

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

Subscription: 8af13382-1cd2-4402-139a-08da7ef5fa55
Build: 20220913.4
Date Produced: September 13, 2022 9:13:12 PM UTC
Commit: 559d9e7ca86eac451a8c840190593fad9fd5b842
Branch: refs/heads/release/7.0

Updates:
- Microsoft.DotNet.ILCompiler: from 7.0.0-rc.2.22459.1 to 7.0.0-rc.2.22463.4
- Microsoft.Extensions.DependencyModel: from 7.0.0-rc.2.22459.1 to 7.0.0-rc.2.22463.4
- Microsoft.NET.HostModel: from 7.0.0-rc.2.22459.1 to 7.0.0-rc.2.22463.4
- Microsoft.NETCore.App.Host.win-x64: from 7.0.0-rc.2.22459.1 to 7.0.0-rc.2.22463.4
- Microsoft.NETCore.App.Ref: from 7.0.0-rc.2.22459.1 to 7.0.0-rc.2.22463.4
- Microsoft.NETCore.App.Runtime.win-x64: from 7.0.0-rc.2.22459.1 to 7.0.0-rc.2.22463.4
- Microsoft.NETCore.DotNetHostResolver: from 7.0.0-rc.2.22459.1 to 7.0.0-rc.2.22463.4
- Microsoft.NETCore.Platforms: from 7.0.0-rc.2.22459.1 to 7.0.0-rc.2.22463.4
- System.CodeDom: from 7.0.0-rc.2.22459.1 to 7.0.0-rc.2.22463.4
- System.Reflection.MetadataLoadContext: from 7.0.0-rc.2.22459.1 to 7.0.0-rc.2.22463.4
- System.Resources.Extensions: from 7.0.0-rc.2.22459.1 to 7.0.0-rc.2.22463.4
- System.Security.Cryptography.ProtectedData: from 7.0.0-rc.2.22459.1 to 7.0.0-rc.2.22463.4
- System.Text.Encoding.CodePages: from 7.0.0-rc.2.22459.1 to 7.0.0-rc.2.22463.4
- VS.Redist.Common.NetCore.SharedFramework.x64.7.0: from 7.0.0-rc.2.22459.1 to 7.0.0-rc.2.22463.4
- VS.Redist.Common.NetCore.TargetingPack.x64.7.0: from 7.0.0-rc.2.22459.1 to 7.0.0-rc.2.22463.4

…0909.6 Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 From Version 7.0.0-rc.2.22459.1 -> To Version 7.0.0-rc.2.22459.6

…0909.15 Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 From Version 7.0.0-rc.2.22459.1 -> To Version 7.0.0-rc.2.22459.15

…0910.1 Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 From Version 7.0.0-rc.2.22459.1 -> To Version 7.0.0-rc.2.22460.1

lewing · 2022-09-10T17:31:04Z

Running C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\msbuild.exe /t:Build C:\h\w\A8270935\t\dotnetSdkTests\p3qcc4v5.3o3\It_contains_d---1AB2B64D\consoledemo.csproj /restore
Process ID: 7028
          CompilerServer: server failed - server rejected the request 'Exception during compilation: The method or operation is not implemented.' - 147222d0-a5c6-4bef-83ad-e9c3bf474fa2
        C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\Roslyn\Microsoft.CSharp.Core.targets(79,5): error :  [C:\h\w\A8270935\t\dotnetSdkTests\p3qcc4v5.3o3\It_contains_d---B5C0C7F2\consoledemo.csproj]
        C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\Roslyn\Microsoft.CSharp.Core.targets(79,5): error : Unhandled Exception: System.NotImplementedException: The method or operation is not implemented. [C:\h\w\A8270935\t\dotnetSdkTests\p3qcc4v5.3o3\It_contains_d---B5C0C7F2\consoledemo.csproj]
        C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\Roslyn\Microsoft.CSharp.Core.targets(79,5): error :    at Microsoft.CodeAnalysis.CommonCompiler.LoggingMetadataFileReferenceResolver.GetHashCode() [C:\h\w\A8270935\t\dotnetSdkTests\p3qcc4v5.3o3\It_contains_d---B5C0C7F2\consoledemo.csproj]
        C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\Roslyn\Microsoft.CSharp.Core.targets(79,5): error :    at Roslyn.Utilities.Hash.Combine[T](T newKeyPart, Int32 currentKey) [C:\h\w\A8270935\t\dotnetSdkTests\p3qcc4v5.3o3\It_contains_d---B5C0C7F2\consoledemo.csproj]
        C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\Roslyn\Microsoft.CSharp.Core.targets(79,5): error :    at Microsoft.CodeAnalysis.CompilationOptions.GetHashCodeHelper() [C:\h\w\A8270935\t\dotnetSdkTests\p3qcc4v5.3o3\It_contains_d---B5C0C7F2\consoledemo.csproj]
        C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\Roslyn\Microsoft.CSharp.Core.targets(79,5): error :    at Microsoft.CodeAnalysis.CSharp.CSharpCompilationOptions.ComputeHashCode() [C:\h\w\A8270935\t\dotnetSdkTests\p3qcc4v5.3o3\It_contains_d---B5C0C7F2\consoledemo.csproj]
        C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\Roslyn\Microsoft.CSharp.Core.targets(79,5): error :    at Microsoft.CodeAnalysis.CompilationOptions.GetHashCode() [C:\h\w\A8270935\t\dotnetSdkTests\p3qcc4v5.3o3\It_contains_d---B5C0C7F2\consoledemo.csproj]
        C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\Roslyn\Microsoft.CSharp.Core.targets(79,5): error :    at System.Collections.Generic.ObjectEqualityComparer`1.GetHashCode(T obj) [C:\h\w\A8270935\t\dotnetSdkTests\p3qcc4v5.3o3\It_contains_d---B5C0C7F2\consoledemo.csproj]
        C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\Roslyn\Microsoft.CSharp.Core.targets(79,5): error :    at System.Collections.Generic.HashSet`1.InternalGetHashCode(T item) [C:\h\w\A8270935\t\dotnetSdkTests\p3qcc4v5.3o3\It_contains_d---B5C0C7F2\consoledemo.csproj]
        C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\Roslyn\Microsoft.CSharp.Core.targets(79,5): error :    at System.Collections.Generic.HashSet`1.AddIfNotPresent(T value) [C:\h\w\A8270935\t\dotnetSdkTests\p3qcc4v5.3o3\It_contains_d---B5C0C7F2\consoledemo.csproj]
        C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\Roslyn\Microsoft.CSharp.Core.targets(79,5): error :    at Microsoft.CodeAnalysis.InputNode`1.UpdateStateTable(Builder graphState, NodeStateTable`1 previousTable, CancellationToken cancellationToken) [C:\h\w\A8270935\t\dotnetSdkTests\p3qcc4v5.3o3\It_contains_d---B5C0C7F2\consoledemo.csproj]

cc @rainersigwald

lambdageek · 2022-09-10T17:32:05Z

C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\Roslyn\Microsoft.CSharp.Core.targets(79,5): error : Unhandled Exception: System.NotImplementedException: The method or operation is not implemented. [C:\h\w\C0860A2E\t\dotnetSdkTests\ea5evhg2.omo\ItCanNewResto---C3AFA90D\ItCanNewResto---C3AFA90D.csproj]
        C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\Roslyn\Microsoft.CSharp.Core.targets(79,5): error :    at Microsoft.CodeAnalysis.CommonCompiler.LoggingMetadataFileReferenceResolver.GetHashCode() [C:\h\w\C0860A2E\t\dotnetSdkTests\ea5evhg2.omo\ItCanNewResto---C3AFA90D\ItCanNewResto---C3AFA90D.csproj]
        C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\Roslyn\Microsoft.CSharp.Core.targets(79,5): error :    at Roslyn.Utilities.Hash.Combine[T](T newKeyPart, Int32 currentKey) [C:\h\w\C0860A2E\t\dotnetSdkTests\ea5evhg2.omo\ItCanNewResto---C3AFA90D\ItCanNewResto---C3AFA90D.csproj]
        C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\Roslyn\Microsoft.CSharp.Core.targets(79,5): error :    at Microsoft.CodeAnalysis.CompilationOptions.GetHashCodeHelper() [C:\h\w\C0860A2E\t\dotnetSdkTests\ea5evhg2.omo\ItCanNewResto---C3AFA90D\ItCanNewResto---C3AFA90D.csproj]
        C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\Roslyn\Microsoft.CSharp.Core.targets(79,5): error :    at Microsoft.CodeAnalysis.CSharp.CSharpCompilationOptions.ComputeHashCode() [C:\h\w\C0860A2E\t\dotnetSdkTests\ea5evhg2.omo\ItCanNewResto---C3AFA90D\ItCanNewResto---C3AFA90D.csproj]
        C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\Roslyn\Microsoft.CSharp.Core.targets(79,5): error :    at Microsoft.CodeAnalysis.CompilationOptions.GetHashCode() [C:\h\w\C0860A2E\t\dotnetSdkTests\ea5evhg2.omo\ItCanNewResto---C3AFA90D\ItCanNewResto---C3AFA90D.csproj]
        C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\Roslyn\Microsoft.CSharp.Core.targets(79,5): error :    at System.Collections.Generic.ObjectEqualityComparer`1.GetHashCode(T obj) [C:\h\w\C0860A2E\t\dotnetSdkTests\ea5evhg2.omo\ItCanNewResto---C3AFA90D\ItCanNewResto---C3AFA90D.csproj]
        C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\Roslyn\Microsoft.CSharp.Core.targets(79,5): error :    at System.Collections.Generic.HashSet`1.InternalGetHashCode(T item) [C:\h\w\C0860A2E\t\dotnetSdkTests\ea5evhg2.omo\ItCanNewResto---C3AFA90D\ItCanNewResto---C3AFA90D.csproj]
        C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\Roslyn\Microsoft.CSharp.Core.targets(79,5): error :    at System.Collections.Generic.HashSet`1.AddIfNotPresent(T value) [C:\h\w\C0860A2E\t\dotnetSdkTests\ea5evhg2.omo\ItCanNewResto---C3AFA90D\ItCanNewResto---C3AFA90D.csproj]

This looks like it might be related to the Roslyn bump, @joperezr ?

lewing · 2022-09-10T17:37:44Z

Would be great to have this unblocked so we can have an rc2 installer before the branch

…ew runtime

joperezr · 2022-09-10T18:24:19Z

This looks like it might be related to the Roslyn bump, @joperezr ?

Yes this is due to the roslyn bump on runtime, particularly on the source generators, and also due to the fact that the sdk repo doesn't build with a recent enough roslyn when compared to those source generators. I've pushed a change that is bumping the roslyn version on the sdk which should resolve this issue.

joperezr · 2022-09-10T20:47:27Z

Seems like even after updating the version of Roslyn used by the repo some full framework tests are failing. After taking a look seems like that is because those tests are invoking VS csc.exe, and it seems like the version it is invoking does not yet have the fix for dotnet/roslyn#63318 . @jaredpar do we know if there is some VS version that has already picked up a csc that has that fix? @marcpopMSFT in case the answer for my previous question is no, would it be possible to disable those tests in full framework until we get a csc.exe with the fix in order to unblock the ingestion of dotnet/runtime into the sdk?

For reference, this is happening since dotnet/runtime has some new generators which depend on a recent version of csc.exe that must have the fix for dotnet/roslyn#63318, and seems like the VS version we use to test in arcade doesn't have that.

rainersigwald · 2022-09-10T21:21:38Z

@joperezr looks like dotnet/roslyn@5d37065 isn't in a release yet. Even if it was, I think those tests run against released VS on a slight lag so it might not be feasible to wait.

One option would be to use RequiresMSBuildVersionFact with a 17.4 version, so the test is disabled until the images get MSBuild 17.4 (+ Roslyn 4.4 with the fix).

lewing · 2022-09-12T23:06:04Z

dotnet/runtime#75490 rolls back the roslyn bump

…0912.6 Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 From Version 7.0.0-rc.2.22459.1 -> To Version 7.0.0-rc.2.22462.6

carlossanlop · 2022-09-13T04:11:02Z

dotnet/runtime#75490 rolls back the roslyn bump

Merged.

v-wuzhai · 2022-09-13T07:10:03Z

/azp run

azure-pipelines · 2022-09-13T07:10:16Z

Azure Pipelines successfully started running 1 pipeline(s).

joperezr · 2022-09-13T17:41:08Z

dotnet/runtime#75490 rolls back the roslyn bump

As FYI, this PR doesn't have the rollback yet. There is an ongoing internal build and once it finishes successfully, this PR will be automatically updated and p ick it up, which should fix the CI failures

…0913.4 Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 From Version 7.0.0-rc.2.22459.1 -> To Version 7.0.0-rc.2.22463.4

lewing · 2022-09-13T22:45:22Z

dotnet/runtime#75490 rolls back the roslyn bump

As FYI, this PR doesn't have the rollback yet. There is an ongoing internal build and once it finishes successfully, this PR will be automatically updated and p ick it up, which should fix the CI failures

a new build has finally made it

kasperk81 · 2022-09-20T14:45:16Z

CompilerServer: server failed - server rejected the request 'Exception during compilation: The method or operation is not implemented.' - 147222d0-a5c6-4bef-83ad-e9c3bf474fa2

after dotnet/runtime#75717, main is blocked by CompilerServer error: #28032. should we bump roslyn or use RequiresMSBuildVersionFact workaround @rainersigwald suggested above #27803 (comment)?

backport of dotnet/runtime#75717 to 7.0 is also in progress. we will be in the same situation in release/7.0.1xx again

jaredpar · 2022-09-20T15:24:17Z

@kasperk81

Do we have a link to the build failure? A binlog we can look at? etc ...

kasperk81 · 2022-09-20T15:38:49Z

@jaredpar at the bottom of logs https://helix.dot.net/api/2019-06-17/jobs/4e8f20ce-2c1b-4e43-99a2-e6d190c5f1a0/workitems/EndToEnd.Tests.dll/console there are helix instructions about dump:

C:\h\w\B348099C\w\C2A509E6\e>C:\python3\python.exe C:\h\w\B348099C\p\reporter\run.py https://dev.azure.com/dnceng-public/ public 474116

jaredpar · 2022-09-20T16:42:06Z

@kasperk81

That is the following bug

dotnet/roslyn#64011

This will be in the next release of VS and .NET SDK. The fix got merged into servicing last night. Packages should be available this morning that we can use in the build to unblock this.

jaredpar · 2022-09-20T17:00:05Z

To work around this:

Need to ensure this NuGet feed is present https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json
Change <MicrosoftNetCompilersToolsetVersion>4.4.0-3.22470.1</MicrosoftNetCompilersToolsetVersion>

That will pick up the patched toolset that has the fix for this problem.

kasperk81 · 2022-09-20T17:12:27Z

nice! nuget feed is there:

sdk/NuGet.config

Line 27 in a44e5fd

    
           <add key="dotnet-tools" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json" />

can someone with access update MicrosoftNetCompilersToolsetVersion version and push a commit to #28032 branch?

jaredpar · 2022-09-20T18:10:44Z

@kasperk81

If we haven't made the change yet we should use version 4.4.0-3.22470.1 instead.

dotnet-issue-labeler bot added the Area-CodeFlow label Sep 10, 2022

dotnet-maestro bot added 2 commits September 10, 2022 07:46

Updating the compiler version to workaround Roslyn issue exposed by n…

8bbfc5d

…ew runtime

lewing approved these changes Sep 14, 2022

View reviewed changes

lewing merged commit 5bc69b1 into release/7.0.1xx Sep 14, 2022

lewing deleted the darc-release/7.0.1xx-7f6564b3-8a20-433f-acae-a1dbbb9a0f0c branch September 14, 2022 00:14

kasperk81 mentioned this pull request Sep 20, 2022

[main] Update dependencies from dotnet/runtime #28032

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release/7.0.1xx] Update dependencies from dotnet/runtime #27803

[release/7.0.1xx] Update dependencies from dotnet/runtime #27803

dotnet-maestro bot commented Sep 10, 2022 •

edited

Loading

lewing commented Sep 10, 2022

lambdageek commented Sep 10, 2022

lewing commented Sep 10, 2022

joperezr commented Sep 10, 2022

joperezr commented Sep 10, 2022

rainersigwald commented Sep 10, 2022

lewing commented Sep 12, 2022

carlossanlop commented Sep 13, 2022

v-wuzhai commented Sep 13, 2022

azure-pipelines bot commented Sep 13, 2022

joperezr commented Sep 13, 2022

lewing commented Sep 13, 2022

kasperk81 commented Sep 20, 2022

jaredpar commented Sep 20, 2022

kasperk81 commented Sep 20, 2022

jaredpar commented Sep 20, 2022

jaredpar commented Sep 20, 2022 •

edited

Loading

kasperk81 commented Sep 20, 2022

jaredpar commented Sep 20, 2022

[release/7.0.1xx] Update dependencies from dotnet/runtime #27803

[release/7.0.1xx] Update dependencies from dotnet/runtime #27803

Conversation

dotnet-maestro bot commented Sep 10, 2022 • edited Loading

From https://github.com/dotnet/runtime

lewing commented Sep 10, 2022

lambdageek commented Sep 10, 2022

lewing commented Sep 10, 2022

joperezr commented Sep 10, 2022

joperezr commented Sep 10, 2022

rainersigwald commented Sep 10, 2022

lewing commented Sep 12, 2022

carlossanlop commented Sep 13, 2022

v-wuzhai commented Sep 13, 2022

azure-pipelines bot commented Sep 13, 2022

joperezr commented Sep 13, 2022

lewing commented Sep 13, 2022

kasperk81 commented Sep 20, 2022

jaredpar commented Sep 20, 2022

kasperk81 commented Sep 20, 2022

jaredpar commented Sep 20, 2022

jaredpar commented Sep 20, 2022 • edited Loading

kasperk81 commented Sep 20, 2022

jaredpar commented Sep 20, 2022

dotnet-maestro bot commented Sep 10, 2022 •

edited

Loading

jaredpar commented Sep 20, 2022 •

edited

Loading