Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0.4xx] Update dependencies from dotnet/templating #24851

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Apr 13, 2022

This pull request updates the following dependencies

From https://github.com/dotnet/templating

  • Subscription: 308fd992-bc5f-42f5-8437-08da19c20afd
  • Build: 20220423.2
  • Date Produced: April 23, 2022 7:42:42 PM UTC
  • Commit: 5744fb6934bf9d9ee28fb9ce9ae2f5b98905e4c1
  • Branch: refs/heads/release/6.0.4xx

…0220413.15

Microsoft.TemplateSearch.Common , Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.Common.ProjectTemplates.6.0 , Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Cli , Microsoft.TemplateEngine.Utils , Microsoft.TemplateEngine.Orchestrator.RunnableProjects
 From Version 6.0.300-preview.22208.4 -> To Version 6.0.400-preview.22213.15
…0220413.17

Microsoft.TemplateSearch.Common , Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.Common.ProjectTemplates.6.0 , Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Cli , Microsoft.TemplateEngine.Utils , Microsoft.TemplateEngine.Orchestrator.RunnableProjects
 From Version 6.0.300-preview.22208.4 -> To Version 6.0.400-preview.22213.17
@gkulin
Copy link
Member

gkulin commented Apr 18, 2022

@nkolev92 it seems like dotnet/templating is depending on a newer version of nuget.common than we are which may be causing some test failures. We just want to verify whether we should also be using 6.3.0 (like templating is) instead of 6.0.2. Please let me and @wtgodbe know what you think

@dotnet/dotnet-cli

…0220419.2

Microsoft.TemplateSearch.Common , Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.Common.ProjectTemplates.6.0 , Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Cli , Microsoft.TemplateEngine.Utils , Microsoft.TemplateEngine.Orchestrator.RunnableProjects
 From Version 6.0.300-preview.22208.4 -> To Version 6.0.400-preview.22219.2
@baronfel
Copy link
Member

It seems ok to me to update to the 6.3.0-previews of the NuGet dependencies, now that we're looking at the 6.0.4xx series of builds.

…0220423.2

Microsoft.TemplateSearch.Common , Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.Common.ProjectTemplates.6.0 , Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Cli , Microsoft.TemplateEngine.Utils , Microsoft.TemplateEngine.Orchestrator.RunnableProjects
 From Version 6.0.300-preview.22208.4 -> To Version 6.0.400-preview.22223.2
@gkulin
Copy link
Member

gkulin commented Apr 27, 2022

@nkolev92 just checking back in on this, since @baronfel recently added his opinion

@nkolev92
Copy link
Contributor

nkolev92 commented Apr 27, 2022

@gkulin

There's always an implicit version between NuGet and SDK.

6.0.4xx should match 6.3.

Example:

https://docs.microsoft.com/en-us/nuget/release-notes/nuget-6.1
6.1 NuGet matches 6.0.200 SDK.

6.0 Nuget matches 6.0.100 SDK.

Eventually, 6.4 of NuGet will match 7.0.100 of the SDK, given that NuGet's versioning is {VSMajorVersion-11}.{VSMinorVersion}

So, 6.0.400 matching 6.3 is exactly what should happen.

@baronfel baronfel force-pushed the darc-release/6.0.4xx-c0afa9f4-71a6-4886-bd62-d53fcec0a68c branch from 896d47c to 01ef5dd Compare April 27, 2022 21:43
@baronfel
Copy link
Member

This should be unblocked when #25013 merges.

@v-wuzhai
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@v-wuzhai v-wuzhai merged commit 6d80c36 into release/6.0.4xx Apr 28, 2022
@dotnet-maestro dotnet-maestro bot deleted the darc-release/6.0.4xx-c0afa9f4-71a6-4886-bd62-d53fcec0a68c branch April 28, 2022 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants