Update .NET Framework targeting pack version #17465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
joeloff
approved these changes
May 6, 2021
jnm2
reviewed
May 6, 2021
| @@ -101,7 +101,7 @@ Copyright (c) .NET Foundation. All rights reserved. | |||
| <DebugSymbols Condition="'$(DebugSymbols)'==''">false</DebugSymbols> | |||
| <CheckForOverflowUnderflow Condition="'$(CheckForOverflowUnderflow)'==''">false</CheckForOverflowUnderflow> | |||
| <AutomaticallyUseReferenceAssemblyPackages Condition="'$(AutomaticallyUseReferenceAssemblyPackages)'==''">true</AutomaticallyUseReferenceAssemblyPackages> | |||
| <MicrosoftNETFrameworkReferenceAssembliesLatestPackageVersion>1.0.0</MicrosoftNETFrameworkReferenceAssembliesLatestPackageVersion> | |||
| <MicrosoftNETFrameworkReferenceAssembliesLatestPackageVersion>1.0.1</MicrosoftNETFrameworkReferenceAssembliesLatestPackageVersion> | |||
There was a problem hiding this comment.
This version has a bug and @NikolaMilosavljevic is working on publishing a fix.
There was a problem hiding this comment.
Can you share a link to the bug? I'm very curious.
There was a problem hiding this comment.
dsplaisted
force-pushed
the
update-targeting-pack-version
branch
from
f2988e9 to
5517012
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to newly released version of Microsoft.NETFramework.ReferenceAssemblies
Fixes microsoft/dotnet#1137
@NikolaMilosavljevic @AArnott