Add the $(VSTestUseConsole) property to the dotnet test command

[mcartoixa]

This PR is a prerequisite for microsoft/vstest#2702. It adds the $(VSTestUseConsole) property to the MSBuild process launched by dotnet test. As a result this command will behave like it does today (cf. microsoft/vstest#680): colorized output, no MSBuild logs.

microsoft/vstest#2702 adds the ability to use MSBuild directly if logs (or node reuse) are more important than colorization.

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

[wli3]

@nohwnd could you review this?

[nohwnd]

There is a long way to merging microsoft/vstest#2702 if we ever decide to do that. Adding this option before we decide and implement the change in VSTest is imho unnecessary. You can specify it in command line as -p directly, or add it as a default value in the msbuild VSTest task to test it out.

I am voting for closing this issue without merging.

[mcartoixa]

Sorry if I was not clear but as designed the statuses of these 2 PRs are linked IMHO. Either merge both or neither of them.
The description of microsoft/vstest#2702 is more complete but it still may need further explanations that I would be more than willing to provide.

[nohwnd]

To me there is no need to keep this PR open until (and if) we make the change in VSTest because the new behavior won't be available till then and this PR will just add to the noise in this repo. This is a 1 line change, that is easy to provide via command line while we refine the behavior on the vstest side.

I don't want to discourage you or anything, we are already internally discussing what to do about your vstest PR, but this PR seems premature.

It's up to the maintainers of this repo, but I'd vote for closing this without merge.