Default to not importing .net framework winfx targets #10998
Conversation
|
any test? |
|
Currently attempting to verify this works locally. |
|
Verified that this works locally. This only affects building using |
|
|
||
| <!-- Workaround: https://github.com/microsoft/msbuild/issues/4948 --> | ||
| <PropertyGroup> | ||
| <ImportFrameworkWinFXTargets>false</ImportFrameworkWinFXTargets> |
There was a problem hiding this comment.
Shouldn't this be placed in WindowsDesktop Sdk targets?
There was a problem hiding this comment.
I may be mistaken but I don't see a WindowsDesktop .targets file? I'm going to merge this in and if it should be placed into a different file I'd be happy to do so.
There was a problem hiding this comment.
The Microsoft.NET.Sdk.WindowsDesktop package in WPF repo.
Moved to: dotnet/wpf#2976
Make it optionally disable: #11606
|
@benvillalobos Is this ready to merge? |
|
This change broke dotnet/roslyn-sdk's WPF projects... |
|
I'm guessing this will break any project using Sdk="Microsoft.NETFramework.Sdk" and targeting desktop (like net472) and using WPF. MSBuildStructuredLogViewer for example. Are we aware that this is a massive breaking change? |
|
Ah, I see there's a fix already: https://github.com/dotnet/sdk/pull/12786/files |
Part 2 fix to dotnet/msbuild#4948
Part 1 is here: dotnet/msbuild#5200
Prevents sdk style projects from importing the .net framework winfx targets.