ConflictResolution doesn't consider project references

[ericstj]

I was trying to reference a project that built a newer version of a dll than one from the shared framework.

I expected conflict resolution to remove the one from the shared framework, but the project reference was never passed to ConflictResolution. As a result both flow through and RAR ignores the project reference. The two files got passed to RAR, shared framework file as a Assemblies parameter and project reference as AssemblyFiles parameter and RAR ignores the latter (not necessarily a bug since we'd be in trouble if it let it through as we wouldn't have removed the runtime item). The app then fails to produce the assets file with NETSDK1007: Cannot file project info for 'path to project reference'. THis can indicate a missing project reference. Indeed it's missing because RAR dropped it.

We should make sure that ConflictResolution sees ProjectReferences and then can handle a conflict where either the project reference or the package reference wins (making the appropriate trims to the assets file to avoid above error).

[vatsan-madhavan]

Just hit this in the wpf repo today. I started building tests by project-referencing WindowsBase.csproj against them, and got into this. I'm working around this by doing something like this, which isn't great.

Would be great if this can be fixed.

  <Target Name="RemoveWindowsBaseFrameworkReference"
          AfterTargets="ResolveTargetingPacks">
    <ItemGroup>
      <Reference Remove="@(Reference)" Condition="'%(FileName)'=='WindowsBase' and '%(Reference.ResolvedFrom)'=='TargetingPack'" />
    </ItemGroup>
  </Target>

[vatsan-madhavan]

Related #3254