Improve failure reporting in tests

dotnet · Dec 4, 2024 · e3da715 · e3da715
1 parent 3906dc5
commit e3da715
Show file tree

Hide file tree

Showing 2 changed files with 130 additions and 162 deletions.
diff --git a/src/BuiltInTools/dotnet-watch/HotReloadDotNetWatcher.cs b/src/BuiltInTools/dotnet-watch/HotReloadDotNetWatcher.cs
@@ -191,10 +191,6 @@ void FileChangedCallback(string path, ChangeKind kind)
                         {
                             ImmutableInterlocked.Update(ref changedFilesAccumulator, changedFiles => changedFiles.Add(changedFile));
                         }
-                        else
-                        {
-                            Context.Reporter.Verbose($"Change ignored: {kind} '{path}'.");
-                        }
                     }
 
                     fileChangedCallback = FileChangedCallback;
@@ -455,6 +451,11 @@ async Task<ImmutableList<ChangedFile>> CaptureChangedFilesSnapshot(ImmutableDict
                 {
                     // start next iteration unless shutdown is requested
                 }
+                catch (Exception) when ((waitForFileChangeBeforeRestarting = false) == true)
+                {
+                    // unreachable
+                    throw new InvalidOperationException();
+                }
                 finally
                 {
                     // stop watching file changes:
@@ -599,6 +600,7 @@ private async ValueTask WaitForFileChangeBeforeRestarting(FileWatcher fileWatche
                 return new ChangedFile(new FileItem { FilePath = path, ContainingProjectPaths = [] }, kind);
             }
 
+            Context.Reporter.Verbose($"Change ignored: {kind} '{path}'.");
             return null;
         }