Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support executing the test host with a specific --fx-version and define a default #205

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Feb 6, 2025

Allow executing the test host with a specific shared framework version (i.e. 10.0.0-ci). This is necessary as i.e. in the VMR, the live built shared framework has a -dev or -ci suffix which could be determined as "lower" than the toolset SDK's shared framework that the repo builds with. As an example 10.0.0-ci and 10.0.0-dev are considered lower than 10.0.0-preview.1 by the host (in accordance with semver2).

Unblocks dotnet/sdk#46558 (requires one update)

…ne a default


Allow executing the test host with a specific shared framework version (i.e. 10.0.0-ci).
This is necessary as i.e. in the VMR, the live built shared framework has a `-dev` or `-ci`
suffix which could be determined as "lower" than the toolset SDK's shared framework that the repo
builds with. As an example `10.0.0-ci` and `10.0.0-dev` are considered lower than `10.0.0-preview.1`
by the host (in accordance with semver2).
@ViktorHofer ViktorHofer enabled auto-merge (squash) February 6, 2025 12:26
@ViktorHofer ViktorHofer merged commit 845f6d0 into main Feb 6, 2025
10 checks passed
@ViktorHofer ViktorHofer deleted the TestFxVersionOverride branch February 6, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants