Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NativeAOT-LLVM] Enable string interop by value #2550

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

maraf
Copy link
Member

@maraf maraf commented Apr 18, 2024

  • Enable string interop by value by default for NativeAOT flavor of dotnet.js
  • Add string interop to smoke test

Constributes to #2434

@maraf maraf added the area-NativeAOT-LLVM LLVM generation for Native AOT compilation (including Web Assembly) label Apr 18, 2024
@maraf maraf requested review from pavelsavara and a team April 18, 2024 12:42
Copy link

@SingleAccretion SingleAccretion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo one comment and given green CI. Thank you!

…stem.Runtime.InteropServices.JavaScript.csproj

Co-authored-by: SingleAccretion <[email protected]>
@maraf maraf merged commit 3924ba1 into dotnet:feature/NativeAOT-LLVM Apr 19, 2024
11 checks passed
@maraf maraf deleted the string-jsinterop branch April 19, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-NativeAOT-LLVM LLVM generation for Native AOT compilation (including Web Assembly)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants