Fix compilation of libunwind on ARM #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
Aug 5, 2021
| @@ -91,9 +91,11 @@ _Unwind_Reason_Code ProcessDescriptors( | |||
| case Descriptor::LU32: | |||
| descriptor = getNextWord(descriptor, &length); | |||
| descriptor = getNextWord(descriptor, &offset); | |||
| break; | |||
There was a problem hiding this comment.
It would be nice to submit this patch to https://github.com/llvm/llvm-project/blob/main/libunwind/src/Unwind-EHABI.cpp as well (it is where this file came from).
|
Already submitted. |
|
@jkotas this link probably should be proper answer. https://reviews.llvm.org/D107537 There should be additional work probably in that direction, so send you the link in case this is interesting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is last issue which prevent compilation on ARM.
So far, I have crash when publish, but that's on .NET 6 Preview 5 I hope. ILC not even running yet.