Improve diagnostics messages for invalid custom native type marshalling and cyclical element info. #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng and cyclical element info.
jkoritzinsky
added
the
area-DllImportGenerator
…elab into better-invalid-marshalinfo-messages
elinor-fung
approved these changes
Jul 8, 2021
DllImportGenerator/DllImportGenerator/MarshallingAttributeInfo.cs
Outdated
Show resolved
Hide resolved
jkoritzinsky
commented
Jul 9, 2021
DllImportGenerator/DllImportGenerator/MarshallingAttributeInfo.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Elinor Fung <[email protected]>
jkoritzinsky
added a commit
to jkoritzinsky/runtime
that referenced
this pull request
Sep 20, 2021
…ng and cyclical element info. (dotnet/runtimelab#1306) Co-authored-by: Elinor Fung <[email protected]> Commit migrated from dotnet/runtimelab@cd18bc4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use custom resource messages to make the diagnostics more localizable.
Further improvements can come once #1299 is in, since it includes more diagnostics validation for the remaining cases.