Resolve SizeParamIndex to a TypePositionInfo during MarshallingInfo parsing #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
added
the
area-DllImportGenerator
DllImportGenerator/DllImportGenerator/MarshallingAttributeInfo.cs
Outdated
Show resolved
Hide resolved
elinor-fung
approved these changes
Jul 7, 2021
| // This ensures that we've unwound the whole cycle so when we return, there will be no cycles in the count info. | ||
| catch (CyclicalCountElementInfoException ex) when (ex.StartOfCycle == param.Name) | ||
| { | ||
| _diagnostics.ReportConfigurationNotSupported(attrData, $"Cyclical {ManualTypeMarshallingHelper.MarshalUsingProperties.CountElementName}"); |
There was a problem hiding this comment.
Should Cyclical {0} be a resource string?
There was a problem hiding this comment.
Probably. I’ll do a follow-up PR to clean up how diagnostics are reported by the marshalling info parser to be a bit cleaner.
|
Are there existing tests for the cyclical count info failure case? |
runtimelab-bot
pushed a commit
that referenced
this pull request
Aug 4, 2021
* Add SslApplicationProtocol.Http3 Fix #1293 * Add XML doc * Reuse in Http3Connection * Reuse in tests * HTTP/3 has no negotiation * Use SslApplicationProtocol.Http3.ToString() in tests * Ascending order in ref
jkoritzinsky
added a commit
to jkoritzinsky/runtime
that referenced
this pull request
Sep 20, 2021
…arsing (dotnet/runtimelab#1293) Commit migrated from dotnet/runtimelab@eea0bae
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the resolution/validation of SizeParamIndex up to MarshallingAttributeInfo.
Enables us to remove the concept of mapping an "index" -> element name/TypePositionInfo from the context and make it only part of the attribute parser. Since this mapping only makes sense in certain scenarios, this allows custom contexts to not have to provide overrides of the
GetTypePositionInfoForManagedIndexmethod that either always returnnullor delegate to a parent context.