Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DllImportGenerator] Reserved keywords support #1096

Closed
SupinePandora43 opened this issue May 8, 2021 · 1 comment · Fixed by #1105
Closed

[DllImportGenerator] Reserved keywords support #1096

SupinePandora43 opened this issue May 8, 2021 · 1 comment · Fixed by #1105
Labels
area-DllImportGenerator Source Generated stubs for P/Invokes in C#

Comments

@SupinePandora43
Copy link 

[GeneratedDllImport("Example")]
internal static partial void MyFunc([MarshalAs(UnmanagedType.LPUTF8Str)] string @event);

Actual Result

CS8795: Partial method 'MyFunc(string)' must have an implementation part because it has accessibility modifiers in source file
CS0759: No defining declaration found for implementing declaration of partial method 'MyFunc(string, event)' in DllImportGenerator.g.cs

Generated code

internal static partial void MyFunc(string event)

Expected Result

Generated code

internal static partial void MyFunc(string @event)
@jkoritzinsky jkoritzinsky added the area-DllImportGenerator Source Generated stubs for P/Invokes in C# label May 8, 2021
jkoritzinsky added a commit to jkoritzinsky/runtimelab that referenced this issue May 10, 2021
@jkoritzinsky
Prepend identifiers with @ symbol since the Roslyn Symbol API strips …
21a591a 
…the @ from the name.

Fixes dotnet#1096
@jkoritzinsky jkoritzinsky mentioned this issue May 10, 2021
Merged
@jkoritzinsky jkoritzinsky linked a pull request May 10, 2021 that will close this issue
Prepend identifiers with @ symbol since the Roslyn Symbol API strips the @ from the name. #1105
Merged
jkoritzinsky added a commit that referenced this issue May 10, 2021
@jkoritzinsky
Prepend identifiers with @ symbol since the Roslyn Symbol API strips …
3c162b8 
…the @ from the name. (#1105)

Fixes #1096
@jkoritzinsky
Copy link
Member

Fixed by #1105

jkoritzinsky added a commit to jkoritzinsky/runtime that referenced this issue Sep 20, 2021
@jkoritzinsky
Prepend identifiers with @ symbol since the Roslyn Symbol API strips …
1cba6dc 
…the @ from the name. (dotnet/runtimelab#1105)

Fixes dotnet/runtimelab#1096

Commit migrated from dotnet/runtimelab@3c162b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-DllImportGenerator Source Generated stubs for P/Invokes in C#
Projects
None yet
Milestone
No milestone
2 participants
@jkoritzinsky @SupinePandora43