Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mt][browser] SignalRClientTests avoid timeouts #99303

Merged
merged 5 commits into from
Mar 6, 2024
Merged

[mt][browser] SignalRClientTests avoid timeouts #99303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
34dfd1f
Avoid closing server before client is closed.
ilonatommy Mar 5, 2024
fa62f18
Follow up for prev commit
ilonatommy Mar 5, 2024
bac9064
Exit client only.
ilonatommy Mar 5, 2024
fede8e2
Merge branch 'main' into fix-99268
jkotas Mar 5, 2024
d6ae6ba
Remove blocking after merge.
ilonatommy Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/mono/wasm/Wasm.Build.Tests/TestAppScenarios/SignalRClientTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ public SignalRClientTests(ITestOutputHelper output, SharedBuildPerTestClassFixtu
}

[ConditionalTheory(typeof(BuildTestBase), nameof(IsWorkloadWithMultiThreadingForDefaultFramework))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/99268", TestPlatforms.Windows)]
[InlineData("Debug", "LongPolling")]
[InlineData("Release", "LongPolling")]
[InlineData("Debug", "WebSockets")]
Expand Down
3 changes: 0 additions & 3 deletions src/mono/wasm/testassets/BlazorHostedApp/BlazorHosted.Client/Pages/Chat.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,7 @@

private async Task SendExitSignal()
{
// exit the server
await _hubConnection.SendAsync("Exit", 0);
await DisposeHubConnection();
Helper.TestOutputWriteLine($"Exit signal was sent by CurrentManagedThreadId={Environment.CurrentManagedThreadId}");
// exit the client
await JSRuntime.InvokeVoidAsync("eval", "import('./dotnet.js').then(module => { module.dotnet; module.exit(0); });");
}
Expand Down
6 changes: 0 additions & 6 deletions src/mono/wasm/testassets/BlazorHostedApp/BlazorHosted.Server/ChatHub.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,4 @@ public async Task SendMessage(string message, int sendingThreadId)
string changedMessage = $"{message}-pong";
await Clients.All.SendAsync("ReceiveMessage", changedMessage).ConfigureAwait(false);
}

public void Exit(int code)
{
Console.WriteLine($"Received exit code {code} from client.");
Environment.Exit(code);
}
}