Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Add missing GT_SWIFT_ERROR case to GenTree:TryGetUse #99120

Merged
merged 1 commit into from
Mar 1, 2024
Merged

JIT: Add missing GT_SWIFT_ERROR case to GenTree:TryGetUse #99120

merged 1 commit into from
Mar 1, 2024

Conversation

amanasifkhalid
Copy link
Member

Fixes #99090.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 29, 2024
@ghost ghost assigned amanasifkhalid Feb 29, 2024
@ghost
Copy link

ghost commented Feb 29, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #99090.

Author: amanasifkhalid
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@amanasifkhalid
Copy link
Member Author

/azp run runtime-coreclr r2r-extra

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Feb 29, 2024
Closed
@amanasifkhalid
Copy link
Member Author

I think runtime-coreclr r2r-extra timed out on OS X arm64, but looking at the test tab, I can see the Swift error handling tests passed.

@amanasifkhalid amanasifkhalid merged commit b4d4c3d into dotnet:main Mar 1, 2024
141 of 152 checks passed
@amanasifkhalid amanasifkhalid deleted the swift-error-stress branch March 1, 2024 04:17
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees

@amanasifkhalid amanasifkhalid

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failure: Interop/Swift/SwiftErrorHandling/SwiftErrorHandling/SwiftErrorHandling.cmd
2 participants
@amanasifkhalid @jakobbotsch