-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move common S.P.CoreLib code under libs #98947
Conversation
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue Detailsnull
|
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Reflection/RuntimeAssembly.cs
Outdated
Show resolved
Hide resolved
I am wondering whether it is intentional for Lines 80 to 81 in 5d14a8d
to throw PNSE instead of calling InternalGetSatelliteAssembly method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Reflection/RuntimeAssembly.cs
Outdated
Show resolved
Hide resolved
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Reflection/RuntimeAssembly.cs
Outdated
Show resolved
Hide resolved
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Reflection/RuntimeAssembly.cs
Outdated
Show resolved
Hide resolved
an.SetPublicKey(GetPublicKey()); | ||
an.Flags = GetFlags() | AssemblyNameFlags.PublicKey; | ||
an.Version = version ?? GetVersion(); | ||
RuntimeAssembly runtimeAssembly = (RuntimeAssembly)assembly; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may look better to keep this as an instance method and do the RuntimeAssembly cast on this
in the one or two places that needs it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've matched mono and nativeaot signature and used it in libraries. Other two do not require an instance method.
7277da5
to
c3126c3
Compare
It seems to be like that for a long time: dotnet/corert@e5892d4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
No description provided.