Fix polluted CompareState when comparing element types in a signature #98198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were propagating state from each type in the method signature to the comparisons for the next type. This resulted in type equivalence checks being disabled for any parameters that came after a generic parameter.
ghost
assigned 
|
I assume the "See" issue can be converted to a "Fixes"? |
AaronRobinsonMSFT
approved these changes
Feb 9, 2024
|
I switched it to 'See' instead of 'Fixes' because wanted to keep it open for a .NET 8 backport. |
3 tasks
|
/backport to release/8.0-staging |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7850043335 |
|
@elinor-fung backporting to release/8.0-staging failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Fix polluted CompareState when comparing element types in a signature
Applying: Add test
Using index info to reconstruct a base tree...
M src/tests/baseservices/typeequivalence/impl/Impls.cs
M src/tests/baseservices/typeequivalence/simple/Simple.cs
Falling back to patching base and 3-way merge...
Auto-merging src/tests/baseservices/typeequivalence/simple/Simple.cs
CONFLICT (content): Merge conflict in src/tests/baseservices/typeequivalence/simple/Simple.cs
Auto-merging src/tests/baseservices/typeequivalence/impl/Impls.cs
CONFLICT (content): Merge conflict in src/tests/baseservices/typeequivalence/impl/Impls.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Add test
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@elinor-fung an error occurred while backporting to release/8.0-staging, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
Merged
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were propagating state from each type in the method signature to the comparisons for the next type. This resulted in type equivalence checks being disabled for any parameters that came after a generic parameter.
See #96268
This regressed in .NET 8.0 after #86932. We probably want to backport, as there isn't really a workaround other than rewriting method signatures.