Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use eng/common/native/init-os-and-arch.sh instead of eng/native/init-os-and-arch.sh #97967

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Use eng/common/native/init-os-and-arch.sh instead of eng/native/init-os-and-arch.sh #97967

merged 2 commits into from
Feb 5, 2024

Conversation

filipnavara
Copy link
Member

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 5, 2024
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 5, 2024
@filipnavara filipnavara added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Feb 5, 2024
@ghost
Copy link

ghost commented Feb 5, 2024

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Ref: #97929 (comment)
Ref: dotnet/arcade#13947

Author: filipnavara
Assignees: -
Labels:

area-Infrastructure, community-contribution
Milestone: -

ViktorHofer
ViktorHofer approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Did you verify that the scripts are identical?

@filipnavara
Copy link
Member Author

Did you verify that the scripts are identical?

Yes, they are

@jkotas jkotas merged commit 4cff20f into dotnet:main Feb 5, 2024
177 of 181 checks passed
@filipnavara filipnavara deleted the common-init-os-and-arch branch February 5, 2024 14:20
This was referenced Feb 5, 2024
Closed
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

@elinor-fung elinor-fung Awaiting requested review from elinor-fung

Assignees
No one assigned
Labels
area-Infrastructure community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@filipnavara @akoeplinger @ViktorHofer @jkotas