Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NativeAOT/ARM] Emit correct unwind codes for VPOP #97710

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

filipnavara
Copy link
Member

Tested on JIT tests

Unwind codes:

0x1c70 <MathCeilingSingle_ro_MathCeilingSingleTest_Program__TestEntryPoint>: @0x428
  Compact model index: 1
  0x01      vsp = vsp + 8
  0xc9 0x81 pop {D8-D9}
  0x84 0x8f pop {r4, r5, r6, r7, r11, r14}
  0xb0      finish

0x37370 <System.Globalization.CalendricalCalculationsHelper__EquationOfTime>: @0x9f54
  Compact model index: 1
  0x09      vsp = vsp + 40
  0xc9 0x86 pop {D8-D14}
  0x84 0x80 pop {r11, r14}
  0xb0      finish

Corresponding prologs:

00001c70 <_fram0MathCeilingSingle_ro_MathCeilingSingleTest_Program__TestEntryPoint>:
    1c70: 2d e9 f0 48   push.w  {r4, r5, r6, r7, r11, lr}
    1c74: 2d ed 04 8b   vpush   {d8, d9}
    1c78: 82 b0         sub     sp, #8

00037370 <_fram0System.Globalization.CalendricalCalculationsHelper__EquationOfTime>:
   37370: 2d e9 00 48   push.w  {r11, lr}
   37374: 2d ed 0e 8b   vpush   {d8, d9, d10, d11, d12, d13, d14}
   37378: 8a b0         sub     sp, #40

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jan 30, 2024
@ghost
Copy link

ghost commented Jan 30, 2024

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Tested on JIT tests

Unwind codes:

0x1c70 <MathCeilingSingle_ro_MathCeilingSingleTest_Program__TestEntryPoint>: @0x428
  Compact model index: 1
  0x01      vsp = vsp + 8
  0xc9 0x81 pop {D8-D9}
  0x84 0x8f pop {r4, r5, r6, r7, r11, r14}
  0xb0      finish

0x37370 <System.Globalization.CalendricalCalculationsHelper__EquationOfTime>: @0x9f54
  Compact model index: 1
  0x09      vsp = vsp + 40
  0xc9 0x86 pop {D8-D14}
  0x84 0x80 pop {r11, r14}
  0xb0      finish

Corresponding prologs:

00001c70 <_fram0MathCeilingSingle_ro_MathCeilingSingleTest_Program__TestEntryPoint>:
    1c70: 2d e9 f0 48   push.w  {r4, r5, r6, r7, r11, lr}
    1c74: 2d ed 04 8b   vpush   {d8, d9}
    1c78: 82 b0         sub     sp, #8

00037370 <_fram0System.Globalization.CalendricalCalculationsHelper__EquationOfTime>:
   37370: 2d e9 00 48   push.w  {r11, lr}
   37374: 2d ed 0e 8b   vpush   {d8, d9, d10, d11, d12, d13, d14}
   37378: 8a b0         sub     sp, #40
Author: filipnavara
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: -

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkotas
Copy link
Member

jkotas commented Jan 30, 2024

/azp run runtime-nativeaot-outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ryujit-bot
Copy link

Diff results for #97710

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

MinOpts (-0.00% to +0.01%)
Collection PDIFF
libraries.pmi.linux.arm64.checked.mch +0.01%

Throughput diffs for windows/arm64 ran on windows/x64

MinOpts (-0.01% to +0.00%)
Collection PDIFF
libraries.pmi.windows.arm64.checked.mch -0.01%

Details here


@ryujit-bot
Copy link

Diff results for #97710

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

MinOpts (-0.00% to +0.01%)
Collection PDIFF
libraries.pmi.linux.arm64.checked.mch +0.01%

Throughput diffs for windows/arm64 ran on windows/x64

MinOpts (-0.01% to +0.00%)
Collection PDIFF
libraries.pmi.windows.arm64.checked.mch -0.01%

Details here


@ryujit-bot
Copy link

Diff results for #97710

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

MinOpts (-0.00% to +0.01%)
Collection PDIFF
libraries.pmi.linux.arm64.checked.mch +0.01%

Details here


@jkotas jkotas merged commit 7e30e61 into dotnet:main Jan 31, 2024
142 of 145 checks passed
@filipnavara filipnavara deleted the naot-arm-vpop branch January 31, 2024 04:27
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-arm32 area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants