[main] Update dependencies from dotnet/roslyn #97152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
…117.18 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.9.0-3.24054.13 -> To Version 4.9.0-3.24067.18
stephentoub
approved these changes
Jan 18, 2024
This was referenced Jan 18, 2024
|
@dotnet/source-build-internal can you please take a look at the prebuilts coming in with this new Roslyn update? |
|
Prebuilts output: Taking a look. |
|
This is just caused by Roslyn upgrading to net8.0 packages. Example from project.assets.json file: Previously: "Microsoft.CodeAnalysis.Workspaces.Common/4.9.0-3.24054.13": {
"type": "package",
"dependencies": {
"Humanizer.Core": "2.14.1",
"Microsoft.Bcl.AsyncInterfaces": "7.0.0",
"Microsoft.CodeAnalysis.Common": "[4.9.0-3.24054.13]",
"System.Composition": "7.0.0",
"System.IO.Pipelines": "7.0.0",
"System.Threading.Channels": "7.0.0"
},Now: "Microsoft.CodeAnalysis.Workspaces.Common/4.9.0-3.24067.18": {
"type": "package",
"dependencies": {
"Humanizer.Core": "2.14.1",
"Microsoft.Bcl.AsyncInterfaces": "8.0.0",
"Microsoft.CodeAnalysis.Common": "[4.9.0-3.24067.18]",
"System.Composition": "8.0.0",
"System.IO.Pipelines": "8.0.0",
"System.Threading.Channels": "8.0.0"
},It can be resolved by adding the reported prebuilts to SBRP. |
…117.18 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.9.0-3.24054.13 -> To Version 4.9.0-3.24067.18
…119.10 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.9.0-3.24054.13 -> To Version 4.9.0-3.24069.10
This was referenced Jan 20, 2024
Closed
…119.10 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.9.0-3.24054.13 -> To Version 4.9.0-3.24069.10
ViktorHofer
added a commit
to dotnet/source-build-reference-packages
that referenced
this pull request
Jan 22, 2024
... necessary to consume new Roslyn dependencies. Roslyn recently updated to 8.0.0 dependencies which makes this change necessary. Unblocks dotnet/runtime#97152
…119.10 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.9.0-3.24054.13 -> To Version 4.9.0-3.24069.10
ViktorHofer
added a commit
to dotnet/source-build-reference-packages
that referenced
this pull request
Jan 22, 2024
* Add Microsoft.CodeAnalysis/4.10 dependencies ... necessary to consume new Roslyn dependencies. Roslyn recently updated to 8.0.0 dependencies which makes this change necessary. Unblocks dotnet/runtime#97152 * Undo incorrect GenAPI changes * Fix order in Build.props
ViktorHofer
approved these changes
Jan 22, 2024
ViktorHofer
approved these changes
Jan 22, 2024
…119.13 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.9.0-3.24054.13 -> To Version 4.10.0-1.24069.13
ViktorHofer
deleted the
darc-main-99eefebb-2987-437f-b7d6-aa5b3a7a4c8c
branch
tmds
pushed a commit
to tmds/runtime
that referenced
this pull request
Jan 23, 2024
* Update dependencies from https://github.com/dotnet/roslyn build 20240117.18 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.9.0-3.24054.13 -> To Version 4.9.0-3.24067.18 * Update dependencies from https://github.com/dotnet/roslyn build 20240117.18 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.9.0-3.24054.13 -> To Version 4.9.0-3.24067.18 * Update dependencies from https://github.com/dotnet/roslyn build 20240119.10 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.9.0-3.24054.13 -> To Version 4.9.0-3.24069.10 * Update dependencies from https://github.com/dotnet/roslyn build 20240119.10 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.9.0-3.24054.13 -> To Version 4.9.0-3.24069.10 * Update dependencies from https://github.com/dotnet/roslyn build 20240119.10 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.9.0-3.24054.13 -> To Version 4.9.0-3.24069.10 * Update SBRP * Update SBRP again * Update SDK as well * Update dependencies from https://github.com/dotnet/roslyn build 20240119.13 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.9.0-3.24054.13 -> To Version 4.10.0-1.24069.13 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Viktor Hofer <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
From https://github.com/dotnet/roslyn