-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compareTypesForEquality #97062
Fix compareTypesForEquality #97062
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
return true; | ||
} | ||
|
||
switch (et1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This improves the original implementation in addition to make it correct. For example, this can prove that KeyValuePair<__Canon, int>
and KeyValuePair<int, __Canon>
are never equal that the original implementation was not able to.
/azp run runtime-nativeaot-outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-nativeaot-outerloop |
@MichalStrehovsky PTLA |
Azure Pipelines successfully started running 1 pipeline(s). |
This bug is not a recent regression for AOT compilers. The test introduced by this change fails with PublishAot and PublishReadyToRun in .NET 8. Any thoughts about whether the backport meets the bar? |
hm.. doesn't repro for me with R2R on net8.0, but does repro with NativeAOT |
Good catch. The pattern matching of The pattern matching of
|
Opened #97134 |
/azp run runtime-nativeaot-outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
We also shipped with it in .NET 7. Not a regression from previous release, no customer reports. Doesn't feel like we have a strong case for backport. |
Fixes #96876