Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename library_exists_in_dir to file_exists_in_dir and remove some unnecessary string allocations #95154

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Rename library_exists_in_dir to file_exists_in_dir and remove some unnecessary string allocations #95154

merged 2 commits into from
Nov 27, 2023

Conversation

elinor-fung
Copy link
Member

  • Rename library_exists_in_dir to file_exists_in_dir
  • Switch string_t parameter to char_t* - removes some unnecessary allocations on startup

Fixes #81355

@ghost
Copy link

ghost commented Nov 23, 2023

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Rename library_exists_in_dir to file_exists_in_dir
  • Switch string_t parameter to char_t* - removes some unnecessary allocations on startup

Fixes #81355

Author: elinor-fung
Assignees: -
Labels:

area-Host
Milestone: -

@ghost ghost assigned elinor-fung Nov 23, 2023
@build-analysis build-analysis bot mentioned this pull request Nov 23, 2023
Closed
vitek-karas
vitek-karas approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elinor-fung elinor-fung merged commit a1db638 into dotnet:main Nov 27, 2023
@elinor-fung elinor-fung deleted the renameUtilsFunc branch November 27, 2023 16:24
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vitek-karas vitek-karas vitek-karas approved these changes

Assignees

@elinor-fung elinor-fung

Labels
area-Host
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[corehost] Return value of library_exists_in_dir is disregarded
2 participants
@elinor-fung @vitek-karas