Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/roslyn-analyzers #94169

Merged
merged 32 commits into from
Nov 29, 2023
Merged

[main] Update dependencies from dotnet/roslyn-analyzers #94169

merged 32 commits into from
Nov 29, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Oct 30, 2023 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn-analyzers

  • Subscription: 5465c78f-1281-49a8-f9b0-08d9301a7704
  • Build: 20231129.3
  • Date Produced: November 29, 2023 10:25:06 AM UTC
  • Commit: d0e4558fd0d73794dcb6eb4d46c12aa57303b69c
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
84c4e39 
…uild 20231029.4

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23529.4
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Oct 30, 2023
This was referenced Oct 30, 2023
Open
Open
Open
@stephentoub
Copy link
Member

@jkoritzinsky, could you take a look at the new error being reported by the analyzer?

src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/AttributeForwarding.cs(439,61): error RS1039: (NETCORE_ENGINEERING_TELEMETRY=Build) A call to 'SemanticModel.GetDeclaredSymbol(LocalFunctionStatementSyntax)' will always return 'null'

@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
ab0b479 
…uild 20231031.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23531.1
This was referenced Oct 31, 2023
Open
Closed
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
32ef115 
…uild 20231031.3

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23531.3
@build-analysis build-analysis bot mentioned this pull request Nov 1, 2023
Closed
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
b3e77bd 
…uild 20231031.3

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23531.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
570cf13 
…uild 20231031.3

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23531.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
ed4b0e7 
…uild 20231031.3

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23531.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
63838b9 
…uild 20231031.3

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23531.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
1ad74dc 
…uild 20231031.3

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23531.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
d8dcf69 
…uild 20231031.3

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23531.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
733360c 
…uild 20231031.3

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23531.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
6cceb2b 
…uild 20231108.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23558.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
3703d09 
…uild 20231108.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23558.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
6e104e1 
…uild 20231108.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23558.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
c5111a1 
…uild 20231108.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23558.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
a56be8d 
…uild 20231108.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23558.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
cb2db7a 
…uild 20231108.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23558.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
49ff8b5 
…uild 20231108.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23558.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
7306058 
…uild 20231108.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23558.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
aaccf3e 
…uild 20231117.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23567.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
195dd7d 
…uild 20231117.2

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23567.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
74807f3 
…uild 20231117.2

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23567.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
d7b820f 
…uild 20231117.2

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23567.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
42b9b99 
…uild 20231117.2

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23567.2
@build-analysis build-analysis bot mentioned this pull request Nov 21, 2023
Closed
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
16b9e53 
…uild 20231117.2

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23567.2
@lewing
Copy link
Member

lewing commented Nov 23, 2023

@jkoritzinsky tagging you again

@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
7e8ddeb 
…uild 20231122.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23572.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
b351726 
…uild 20231122.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23572.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
582b576 
…uild 20231122.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23572.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
8be02ef 
…uild 20231122.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23572.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
01d02b2 
…uild 20231122.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23572.1
@build-analysis build-analysis bot mentioned this pull request Nov 27, 2023
Closed
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
ff2031e 
…uild 20231122.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23572.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
7f69ed2 
…uild 20231129.3

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23523.1 -> To Version 3.11.0-beta1.23579.3
@jkoritzinsky
Copy link
Member

Sorry, I missed this. I'll take a look.

@jkoritzinsky
Copy link
Member

It looks like this analyzer is overzealous and is incorrect as if it were correct, these tests would be failing with an NullReferenceException. I'll disable the warning and file an issue.

@jkoritzinsky
Copy link
Member

Failures are all network blips. Merging this in.

@jkoritzinsky jkoritzinsky merged commit ad70fe7 into main Nov 29, 2023
184 of 191 checks passed
@jkoritzinsky jkoritzinsky deleted the darc-main-90a732d0-c462-4bc6-a777-3c23a2ec063b branch November 29, 2023 20:58
This was referenced Nov 29, 2023
Closed
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephentoub @lewing @jkoritzinsky