[mono][debugger] Improve debugger features #94066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
thaystg
commented
Oct 26, 2023
thaystg
commented
- Creating new messages
- Fixing some messages or adding extra information.
- Fixing when jit_end is called while running a invoke_method
… called while running a invoke_method
ghost
assigned 
|
Tagging subscribers to this area: @thaystg Issue Details
|
lambdageek
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Looks good.
- A couple of places that look at
MonoClassField:typeneed hot reload protection. - It would be better if we didn't copy/paste the code from
ves_icall_System_Runtime_CompilerServices_RuntimeHelpers_GetSpanDataFrom - The new
MDBGPROT_CMD_APPDOMAIN_GET_TYPEcommand is kind of weird - I wonder if you can specialize it only for arrays (so it errors out iftypeis notMONO_TYPE_SZARRAY||MONO_TYPE_ARRAY). Or is this supposed to emulate some CoreCLR behavior (in that case, please add a comment that it has to do it in this weird way)
This was referenced Oct 27, 2023
lambdageek
approved these changes
Nov 21, 2023
| @@ -7940,6 +7950,42 @@ domain_commands (int command, guint8 *p, guint8 *end, Buffer *buf) | |||
| buffer_add_objid (buf, o); | |||
| break; | |||
| } | |||
| case MDBGPROT_CMD_APPDOMAIN_GET_TYPE: { | |||
There was a problem hiding this comment.
it it only works on arrays? why is it called "get type" and not something like "create array type"
There was a problem hiding this comment.
It works also for pointers, but I'm not sure how to implement it yet, that is why I didn't implement.
This was referenced Nov 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.