-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Fix Vector128 SIMD fmin and fmax #93556
[wasm] Fix Vector128 SIMD fmin and fmax #93556
Conversation
So that it propagates NaNs
…lues` (dotnet#92953)" This reverts commit 01cab29.
/azp run runtime-wasm-libtests |
Azure Pipelines successfully started running 1 pipeline(s). |
I think we can try to unify all the platforms to use |
@radical @ilonatommy are the hybrid globalization tests failing in main? ah #93354 |
Failed tests are hybrid globalization, the
|
/backport to release/8.0 |
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6545017032 |
@radekdoulik an error occurred while backporting to release/8.0, please check the run log for details! Error: @radekdoulik is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=radekdoulik |
/backport to release/8.0 |
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6548822124 |
@radekdoulik backporting to release/8.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: [wasm] Fix SIMD fmin and fmax
Applying: Revert "[wasm] Disable `TensorPrimitivesTests.ConvertToHalf_SpecialValues` (#92953)"
Using index info to reconstruct a base tree...
M src/libraries/System.Numerics.Tensors/tests/TensorPrimitivesTests.netcore.cs
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/System.Numerics.Tensors/tests/TensorPrimitivesTests.netcore.cs
CONFLICT (content): Merge conflict in src/libraries/System.Numerics.Tensors/tests/TensorPrimitivesTests.netcore.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Revert "[wasm] Disable `TensorPrimitivesTests.ConvertToHalf_SpecialValues` (#92953)"
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128 Please backport manually! |
@radekdoulik an error occurred while backporting to release/8.0, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
Fix #92885
Min and max now use NaN propagating SIMD instructions,
f32x4.min
,f64x2.min
,f32x4.max
andf64x2.max
.Example emitted code:
for