-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0] Workaround for C++ compiler bug on Arm64 #93528
Conversation
Tagging subscribers to this area: @tommcdon Issue DetailsBackport of #93523 to release/8.0 MSVC rolled out to the build machines a few days ago has a codegen bug that affects the JIT on Arm64. We are applying a temporary workaround to disable optimizations around the affected methods. Customer ImpactMultiplication of two constants produce bad result in some cases. TestingThe affected JIT tests are passing. RiskLow
|
/backport to release/7.0 |
/backport to release/6.0 |
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/6525097146 |
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/6525097808 |
@jkotas backporting to release/6.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Delete outdated workaround
Applying: Workaround for https://github.com/dotnet/runtime/issues/93442
Using index info to reconstruct a base tree...
M src/coreclr/inc/safemath.h
Falling back to patching base and 3-way merge...
Auto-merging src/coreclr/inc/safemath.h
CONFLICT (content): Merge conflict in src/coreclr/inc/safemath.h
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Workaround for https://github.com/dotnet/runtime/issues/93442
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128 Please backport manually! |
@jkotas an error occurred while backporting to release/6.0, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsBackport of #93523 to release/8.0 MSVC rolled out to the build machines a few days ago has a codegen bug that affects the JIT on Arm64. We are applying a temporary workaround to disable optimizations around the affected methods. Customer ImpactMultiplication of two constants produce bad result in some cases. TestingThe affected JIT tests are passing. RiskLow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. we will take for consideration in 8.0.x
c4173df
to
2c7fd4d
Compare
Backport of #93523 to release/8.0
MSVC rolled out to the build machines a few days ago has a codegen bug that affects the JIT on Arm64. We are applying a temporary workaround to disable optimizations around the affected methods.
Customer Impact
Multiplication of two constants produces bad result in some cases.
Testing
The affected JIT tests are passing.
Risk
Low