Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Workaround for C++ compiler bug on Arm64 #93528

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Oct 15, 2023

Backport of #93523 to release/8.0

MSVC rolled out to the build machines a few days ago has a codegen bug that affects the JIT on Arm64. We are applying a temporary workaround to disable optimizations around the affected methods.

Customer Impact

Multiplication of two constants produces bad result in some cases.

Testing

The affected JIT tests are passing.

Risk

Low

@ghost
Copy link

ghost commented Oct 15, 2023

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #93523 to release/8.0

MSVC rolled out to the build machines a few days ago has a codegen bug that affects the JIT on Arm64. We are applying a temporary workaround to disable optimizations around the affected methods.

Customer Impact

Multiplication of two constants produce bad result in some cases.

Testing

The affected JIT tests are passing.

Risk

Low

Author: jkotas
Assignees: jkotas
Labels:

area-Diagnostics-coreclr

Milestone: -

@jkotas jkotas added Servicing-consider Issue for next servicing release review and removed area-Diagnostics-coreclr labels Oct 15, 2023
@jkotas jkotas requested a review from jakobbotsch October 15, 2023 15:56
@jkotas
Copy link
Member Author

jkotas commented Oct 15, 2023

/backport to release/7.0

@jkotas
Copy link
Member Author

jkotas commented Oct 15, 2023

/backport to release/6.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/6525097146

@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/6525097808

@github-actions
Copy link
Contributor

@jkotas backporting to release/6.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Delete outdated workaround
Applying: Workaround for https://github.com/dotnet/runtime/issues/93442
Using index info to reconstruct a base tree...
M	src/coreclr/inc/safemath.h
Falling back to patching base and 3-way merge...
Auto-merging src/coreclr/inc/safemath.h
CONFLICT (content): Merge conflict in src/coreclr/inc/safemath.h
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Workaround for https://github.com/dotnet/runtime/issues/93442
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@github-actions
Copy link
Contributor

@jkotas an error occurred while backporting to release/6.0, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

@jkotas jkotas added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 15, 2023
@ghost
Copy link

ghost commented Oct 15, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #93523 to release/8.0

MSVC rolled out to the build machines a few days ago has a codegen bug that affects the JIT on Arm64. We are applying a temporary workaround to disable optimizations around the affected methods.

Customer Impact

Multiplication of two constants produce bad result in some cases.

Testing

The affected JIT tests are passing.

Risk

Low

Author: jkotas
Assignees: jkotas
Labels:

Servicing-consider, area-CodeGen-coreclr

Milestone: -

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in 8.0.x

@jeffschwMSFT jeffschwMSFT added this to the 8.0.0 milestone Oct 15, 2023
@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 16, 2023
@jkotas jkotas merged commit 324f912 into dotnet:release/8.0 Oct 16, 2023
111 of 112 checks passed
@jkotas jkotas deleted the issue-93442-8.0 branch October 16, 2023 18:30
@ghost ghost locked as resolved and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants