(chore) set min version of cmake in native CmakeLists.txt to surpass Cmake CMP0000 policy warning #93437

Neo-vortex · 2023-10-13T01:44:05Z

This closes #93436

Setting the min version for cmake reflecting https://github.com/dotnet/runtime/blob/main/src/native/libs/CMakeLists.txt

…policy CMP0000 of Cmake

ghost · 2023-10-13T01:44:17Z

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

This closes #93436

Author:	Neo-vortex
Assignees:	-
Labels:	`area-Infrastructure-libraries`
Milestone:	-

Neo-vortex · 2023-10-13T01:45:12Z

@dotnet-policy-service agree

ViktorHofer · 2023-10-13T06:34:55Z

cc @jkoritzinsky as you dealt with minimum cmake versions in our repo in the past

src/native/libs/System.Globalization.Native/CMakeLists.txt

src/native/libs/System.IO.Compression.Native/CMakeLists.txt

src/native/libs/System.IO.Ports.Native/CMakeLists.txt

src/native/libs/System.Security.Cryptography.Native/CMakeLists.txt

src/native/libs/System.Native/CMakeLists.txt

src/native/libs/System.Net.Security.Native/CMakeLists.txt

src/native/libs/System.Security.Cryptography.Native.Android/CMakeLists.txt

src/native/libs/System.Security.Cryptography.Native.Apple/CMakeLists.txt

….txt

jkotas

Thank you

src/native/libs/System.Globalization.Native/CMakeLists.txt

src/native/libs/System.Security.Cryptography.Native/CMakeLists.txt

hange the minimum version to 3.16 to be consistent with other CMake scripts for System.Globalization.Native/CMakeLists.txt Co-authored-by: Jeremy Koritzinsky <[email protected]>

….txt change the minimum version to 3.16 to be consistent with other CMake scripts for System.Globalization.Native/CMakeLists.txt Co-authored-by: Jeremy Koritzinsky <[email protected]>

am11 · 2023-10-13T17:03:38Z

src/native/libs/System.Globalization.Native/CMakeLists.txt

@@ -1,3 +1,6 @@
+# Required for StaticICULinking
+cmake_minimum_required(VERSION 3.16...3.20)


What happens when we have > 3.20 installed? Do we want to restrict on max value or can it just be set to 3.16 minimum?

you are right.
limiting the max version is probably not what we want to do.
we can set cmake_minimum_required(VERSION 3.16)
fixed in the latest commit

This is not setting a max version. This is setting the version of CMake to set the policy values for. Setting it to 3.20 ensures that for the dotnet/runtime build, we use a consistent set of CMake policy configurations.

jkotas · 2023-10-13T17:22:33Z

How did you come up with 3.16?

It would be better for this version to match the min cmake version used in the rest of the repo.

am11 · 2023-10-13T17:42:19Z

How did you come up with 3.16?

@jkotas, please expand the comments to see the history. It was a comment from @jkoritzinsky to use the version range 3.16...3.20, on which I commented that maybe we don't need to restrict to the max value. I think some old distros are providing older versions, so it makes sense to lower the requirements of "shipping" cmake script, which are not using any new feature.

jkoritzinsky · 2023-10-13T17:52:36Z

3.16 is the minimum required version for the CMake scripts we use to build Apple and Android apps on customer machines (see the CMake templates in AppleAppBuilder and AndroidAppBuilder).

Neo-vortex · 2023-10-13T18:43:41Z

@jkotas
if @jkoritzinsky is right about the min cmake version, probably when can merge this PR as is.

jkotas · 2023-10-14T05:51:13Z

I do not see a strong reason for keeping the Apple/Android builder min cmake version to be in sync with min cmake version for this Linux-specific opt-in option.

I see the following options:

Use 3.20 to keep things simple.
Use 3.16..3.20. As @jkoritzinsky pointed out, it is important to set 3.20 as the upper bound so that the dotnet/runtime build uses consistent set of policies.
Match cmake version that comes with the oldest Linux distro supported by .NET runtime. If it is going Ubuntu 18.04 for .NET 9, it would make it 3.10..3.20.

am11 · 2023-10-14T05:59:23Z

it is important to set 3.20 as the upper bound so that the dotnet/runtime build uses consistent set of policies.

We don't have any restriction on > 3.20 version. In fact, the minimum version is 3.20.

runtime/src/coreclr/CMakeLists.txt

Line 1 in 765798c

cmake_minimum_required(VERSION 3.20)

jkoritzinsky · 2023-10-14T06:08:32Z

it is important to set 3.20 as the upper bound so that the dotnet/runtime build uses consistent set of policies.

We don't have any restriction on > 3.20 version. In fact, the minimum version is 3.20.

runtime/src/coreclr/CMakeLists.txt

Line 1 in 765798c

cmake_minimum_required(VERSION 3.20)

One aspect of setting the minimum required as 3.20 in that was is to set the CMake policy defaults to the 3.20 rules, no matter the version of CMake that’s actually running the build. Using the 3.10…3.20 syntax says “3.10 is the minimum required version for the features used. Use the newest version of CMake policies available until 3.20. Then use the 3.20 policy defaults”

Neo-vortex · 2023-10-14T08:42:48Z

it is important to set 3.20 as the upper bound so that the dotnet/runtime build uses consistent set of policies.

We don't have any restriction on > 3.20 version. In fact, the minimum version is 3.20.

runtime/src/coreclr/CMakeLists.txt

Line 1 in 765798c

cmake_minimum_required(VERSION 3.20)

One aspect of setting the minimum required as 3.20 in that was is to set the CMake policy defaults to the 3.20 rules, no matter the version of CMake that’s actually running the build. Using the 3.10…3.20 syntax says “3.10 is the minimum required version for the features used. Use the newest version of CMake policies available until 3.20. Then use the 3.20 policy defaults”

so 3.10..3.20 is the the best practice here where :
1- builds fail on anything below 3.10
2- anything above 3.20 would use 3.20 policy defaults

(chore) set min version of cmake in native CmakeLists.txt to surpass …

88771c7

…policy CMP0000 of Cmake

dotnet-issue-labeler bot added the area-Infrastructure-libraries label Oct 13, 2023

ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 13, 2023

(chore) set all cmake versions according to native/libs/CMakeLists.txt

897660b

jkotas reviewed Oct 13, 2023

View reviewed changes

jkotas added 2 commits October 13, 2023 05:29

Apply suggestions from code review

b70c99e

Update src/native/libs/System.Security.Cryptography.Native/CMakeLists…

41c0f68

….txt

jkotas approved these changes Oct 13, 2023

View reviewed changes

jkotas requested a review from jkoritzinsky October 13, 2023 12:30

build-analysis bot mentioned this pull request Oct 13, 2023

System.Data.OleDb.Tests timeout in net48 x86 Release leg #87783

Open

jkoritzinsky reviewed Oct 13, 2023

View reviewed changes

src/native/libs/System.Globalization.Native/CMakeLists.txt Outdated Show resolved Hide resolved

src/native/libs/System.Security.Cryptography.Native/CMakeLists.txt Outdated Show resolved Hide resolved

Neo-vortex and others added 2 commits October 13, 2023 20:31

Update src/native/libs/System.Globalization.Native/CMakeLists.txt

a8bcbae

hange the minimum version to 3.16 to be consistent with other CMake scripts for System.Globalization.Native/CMakeLists.txt Co-authored-by: Jeremy Koritzinsky <[email protected]>

Update src/native/libs/System.Security.Cryptography.Native/CMakeLists…

0f7a6ec

….txt change the minimum version to 3.16 to be consistent with other CMake scripts for System.Globalization.Native/CMakeLists.txt Co-authored-by: Jeremy Koritzinsky <[email protected]>

am11 reviewed Oct 13, 2023

View reviewed changes

(chore) set min version for cmake to 3.16

47efbe4

build-analysis bot mentioned this pull request Oct 14, 2023

Test failure: JIT/opt/AssertionPropagation/ArrBoundElim/ArrBoundElim.dll #93508

Closed

(chore) set min cmae version to 3.10

2872c7a

Neo-vortex requested a review from jkoritzinsky October 14, 2023 11:26

jkoritzinsky approved these changes Oct 14, 2023

View reviewed changes

jkotas mentioned this pull request Oct 14, 2023

Test failure: Wasm.Build.Tests.NativeBuildTests.MonoAOTCross_WorksWithNoTrimming #93522

Closed

jkotas merged commit 5233eea into dotnet:main Oct 14, 2023
183 of 187 checks passed

ghost locked as resolved and limited conversation to collaborators Nov 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(chore) set min version of cmake in native CmakeLists.txt to surpass Cmake CMP0000 policy warning #93437

(chore) set min version of cmake in native CmakeLists.txt to surpass Cmake CMP0000 policy warning #93437

Neo-vortex commented Oct 13, 2023 •

edited

Loading

ghost commented Oct 13, 2023

Neo-vortex commented Oct 13, 2023

ViktorHofer commented Oct 13, 2023

jkotas left a comment

am11 Oct 13, 2023

Neo-vortex Oct 13, 2023

jkoritzinsky Oct 13, 2023

jkotas commented Oct 13, 2023

am11 commented Oct 13, 2023

jkoritzinsky commented Oct 13, 2023

Neo-vortex commented Oct 13, 2023

jkotas commented Oct 14, 2023

am11 commented Oct 14, 2023

jkoritzinsky commented Oct 14, 2023

Neo-vortex commented Oct 14, 2023

		@@ -1,3 +1,6 @@
		# Required for StaticICULinking
		cmake_minimum_required(VERSION 3.16...3.20)

(chore) set min version of cmake in native CmakeLists.txt to surpass Cmake CMP0000 policy warning #93437

(chore) set min version of cmake in native CmakeLists.txt to surpass Cmake CMP0000 policy warning #93437

Conversation

Neo-vortex commented Oct 13, 2023 • edited Loading

ghost commented Oct 13, 2023

Neo-vortex commented Oct 13, 2023

ViktorHofer commented Oct 13, 2023

jkotas left a comment

Choose a reason for hiding this comment

am11 Oct 13, 2023

Choose a reason for hiding this comment

Neo-vortex Oct 13, 2023

Choose a reason for hiding this comment

jkoritzinsky Oct 13, 2023

Choose a reason for hiding this comment

jkotas commented Oct 13, 2023

am11 commented Oct 13, 2023

jkoritzinsky commented Oct 13, 2023

Neo-vortex commented Oct 13, 2023

jkotas commented Oct 14, 2023

am11 commented Oct 14, 2023

jkoritzinsky commented Oct 14, 2023

Neo-vortex commented Oct 14, 2023

Neo-vortex commented Oct 13, 2023 •

edited

Loading