[RISC-V] Fixing createdump for RISC-V #93374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @tommcdon Issue DetailsFixing errors to make dumps in RISC-V. Part of #84834
|
|
cc @viewizard |
This was referenced Oct 13, 2023
Closed
Closed
clamp03
changed the title
|
@jkotas Could you take a look at this PR? Thank you. |
jkotas
reviewed
Oct 23, 2023
Comment on lines
134
to
141
| #ifndef HOST_WINDOWS | ||
| // In windows, IMAGE_FILE_MACHINE_RISCV64 is not declared yet. | ||
| case IMAGE_FILE_MACHINE_RISCV64: | ||
| ulExpectedPointerSize = 8; | ||
| platform = CORDB_PLATFORM_POSIX_RISCV64; | ||
| break; | ||
| #endif // HOST_WINDOWS | ||
|
|
There was a problem hiding this comment.
Suggested change
| #ifndef HOST_WINDOWS | |
| // In windows, IMAGE_FILE_MACHINE_RISCV64 is not declared yet. | |
| case IMAGE_FILE_MACHINE_RISCV64: | |
| ulExpectedPointerSize = 8; | |
| platform = CORDB_PLATFORM_POSIX_RISCV64; | |
| break; | |
| #endif // HOST_WINDOWS | |
| case IMAGE_FILE_MACHINE_RISCV64: | |
| ulExpectedPointerSize = 8; | |
| platform = CORDB_PLATFORM_POSIX_RISCV64; | |
| break; | |
And instead add the following somewhere (src/coreclr/inc/clrint.h may be a good place):
#ifndef IMAGE_FILE_MACHINE_RISCV64
#define IMAGE_FILE_MACHINE_RISCV64 0x5064 // RISCV64
#endif
2a03159 to
a4d98aa
Compare
jkotas
approved these changes
Oct 23, 2023
|
Thank you! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial patch for createdump. Fixed errors when to make dumps in RISC-V only.
I didn't check generated dump is correct yet. I will check later when others are prepared.
Part of #84834
cc @wscho77 @HJLeee @JongHeonChoi @t-mustafin @gbalykov @tomeksowi @sirntar @yurai007