Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary rid argument to dotnet-restore #91844

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Remove unnecessary rid argument to dotnet-restore #91844

merged 1 commit into from
Oct 23, 2023

Conversation

am11
Copy link
Member

@am11 am11 commented Sep 9, 2023 •
edited
Loading

We build managed tests with AnyCPU configuration. This -r PackageRID causes errors during the restore when cross building for different OS (-os $other and not different arch).

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 9, 2023
@ghost
Copy link

ghost commented Sep 9, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: am11
Assignees: -
Labels:

area-Infrastructure-coreclr, community-contribution
Milestone: -

@am11 am11 marked this pull request as ready for review September 9, 2023 21:27
@am11
Copy link
Member Author

am11 commented Sep 9, 2023

mono interpreter segmentation fault seems unrelated (possibly #67405).

@am11 am11 requested a review from ViktorHofer September 11, 2023 21:23
agocke
agocke approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agocke agocke merged commit e8287ad into dotnet:main Oct 23, 2023
95 of 99 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Nov 23, 2023
@am11 am11 deleted the patch-23 branch June 14, 2024 04:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@agocke agocke agocke approved these changes

Assignees
No one assigned
Labels
area-Infrastructure-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@am11 @agocke @ViktorHofer