SPMI: Hacky workaround for coredistools unsupported instructions #91668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently are unable to get SPMI diffs for methods that use ldapur instructions as our current coredistools does not support this instruction. While we wait for coredistools to be updated (this was blocked on some C++ lib issues) here is a hacky temporary workaround for the problem. It rewrites ldapur* instructions into the corresponding ldur* instruction before passing it to the near differ.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsWe currently are unable to get SPMI diffs for methods that use ldapur
|
|
/azp run runtime-coreclr superpmi-replay, runtime-coreclr superpmi-diffs |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run runtime-coreclr superpmi-replay, runtime-coreclr superpmi-diffs |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
cc @dotnet/jit-contrib PTAL @BruceForstall No diffs -- fixes the "0 sized diffs" on arm64 we have been seeing recently. Only to be used as a temporary hack while coredistools is outdated. |
This reverts commit 593fb3a.
BruceForstall
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
That's quite a hack :-)
It would be useful to add a comment about why this code is there, and what it is trying to do. Maybe link to an issue (or two) indicating how it should be ultimately fixed (and the issue can point out to remove this code after coredistools is updated).
|
@jakobbotsch Are you planning to merge this? I wonder if it's contributing to the checked/release asm diffs failures, e.g. https://dev.azure.com/dnceng-public/public/_build/results?buildId=401020&view=logs&j=83516c17-6666-5250-abde-63983ce72a49 |
Done. Yeah, I think the AV could be related. I would expect it to be fixed either by this or #91783. I kicked off https://dev.azure.com/dnceng-public/public/_build/results?buildId=404846&view=results. |
|
Looks like the x64 run passed, but the x86 run timed out. I think I forgot to increase the imtout of superpmi-asmdiffs-checked-release in #91637. |
|
The console logs are odd, though: they finish at the end of the download phase, after less than 10 minutes, with no evidence the replay/run phase even started. |
|
|
ah, ok. so the timeouts do need to be increased. fwiw, I ran the failing cases locally and got no diffs. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently are unable to get SPMI diffs for methods that use ldapur
instructions as our current coredistools does not support this
instruction. While we wait for coredistools to be updated (this was
blocked on some C++ lib issues) here is a hacky temporary workaround for
the problem. It rewrites ldapur* instructions into the corresponding
ldur* instruction before passing it to the near differ.