-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LoongArch64, RISC-V] Fix handling ThreadAbortException at the end of catch for LoongArch64 and RISC-V. #91531
Conversation
This PR mainly fixes Testing: @@@@@ home/xuliangyu/libs-8-tests/System.Runtime.Tests/Release/net8.0-unix @@@@@ Discovering: System.Runtime.Tests (method display = ClassAndMethod, method display options = None) Discovered: System.Runtime.Tests (found 9232 of 9279 test cases) Starting: System.Runtime.Tests (parallel test collections = on, max threads = 4) System.Tests.ArgIteratorTests.ArgIterator_GetNextArgType [SKIP] Condition(s) not met: "IsArgIteratorSupported" System.Tests.ArgIteratorTests.ArgIterator_GetRemainingCount_GetNextArg [SKIP] Condition(s) not met: "IsArgIteratorSupported" System.Tests.StringTests.IndexOf_SingleLetter(s: "Hello", target: '\0', startIndex: 0, count: 5, expected: -1) [SKIP] Target \0 is not supported in ICU System.Tests.StringTests.LastIndexOf_NullInStrings [SKIP] Condition(s) not met: "IsNlsGlobalization" System.Tests.StringTests.IndexOf_NullInStrings [SKIP] Condition(s) not met: "IsNlsGlobalization" System.Tests.StringTests.EndsWith_NullInStrings_NonOrdinal [SKIP] Condition(s) not met: "IsNlsGlobalization" System.Tests.StringTests.StartsWith_NullInStrings_NonOrdinal [SKIP] Condition(s) not met: "IsNlsGlobalization" System.Tests.StringTests.EndsWith_NullInStrings [SKIP] Condition(s) not met: "IsNlsGlobalization" System.Tests.StringTests.StartsWith_NullInStrings [SKIP] Condition(s) not met: "IsNlsGlobalization" System.Runtime.Tests.JitInfoTests.JitInfoIsNotPopulated [SKIP] Condition(s) not met: "IsMonoAOT" System.Tests.DateTimeOffsetTests.ToLocalTime_MinValue [SKIP] Condition(s) not met: "IsMinValueNegativeLocalOffset" System.Tests.DateTimeOffsetTests.ToLocalTime_Ambiguous [SKIP] Condition(s) not met: "IsPacificTime" System.Tests.TimeZoneInfoTests.UnsupportedImplicitConversionTest [SKIP] Condition(s) not met: "DoesNotSupportIanaNamesConversion" Finished: System.Runtime.Tests === TEST EXECUTION SUMMARY === System.Runtime.Tests Total: 65391, Errors: 0, Failed: 0, Skipped: 13, Time: 42.992s |
cc @shushanhf ,Could you please review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks
1ceeecc
to
3405fef
Compare
3405fef
to
77907a4
Compare
cc @clamp03 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!!!
@jkotas Could you please review this PR ? |
Use RedirectForThreadAbort to call ThrowControlForThread directly.
Use RedirectForThreadAbort to call ThrowControlForThread directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR is part of the issue #69705 to amend the LA's port.
Fix handling ThreadAbortException at the end of catch for LoongArch64 and RISC-V.