Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] [wasm] Add link to docs to interop error messages #91378

Closed
wants to merge 2 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 31, 2023

Backport of #91328 to release/8.0

/cc @maraf

Customer Impact

User that run into an unsupported scenario in JS interop get an error message containing a link to docs

Example

error SYSLIB1072: The type 'Task<int[]>' is not supported by source-generated JavaScript interop. The generated source will not handle marshalling of parameter 'meaning'. For more information see https://aka.ms/dotnet-wasm-jsinterop

Testing

Manual

Risk

None

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Aug 31, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #91328 to release/8.0

/cc @maraf

Customer Impact

User that run into an unsupported scenario in JS interop get an error message containing a link to docs

Example

error SYSLIB1072: The type 'Task<int[]>' is not supported by source-generated JavaScript interop. The generated source will not handle marshalling of parameter 'meaning'. For more information see https://aka.ms/dotnet-wasm-jsinterop

Testing

Manual

Risk

None

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript

Milestone: -

@maraf maraf added this to the 8.0.0 milestone Aug 31, 2023
@carlossanlop carlossanlop added the Servicing-consider Issue for next servicing release review label Aug 31, 2023
@carlossanlop
Copy link
Member

@lewing / @steveisok / @marek-safar do we have your blessing for this change?

@maraf
Copy link
Member

maraf commented Aug 31, 2023

Needs to be merged together with #91398. I'll update this PR once that one is merged

@carlossanlop
Copy link
Member

Needs to be merged together with #91398. I'll update this PR once that one is merged

Thanks for the heads up, @maraf. I'll add the blocked label. Please remove it once this is ready to merge.

@carlossanlop carlossanlop added the blocked Issue/PR is blocked on something - see comments label Aug 31, 2023
@maraf
Copy link
Member

maraf commented Aug 31, 2023

The fix is not working, I'm reverting the original PR and do it again from scratch.

@maraf maraf closed this Aug 31, 2023
@jkotas jkotas deleted the backport/pr-91328-to-release/8.0 branch September 5, 2023 01:01
@ghost ghost locked as resolved and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript blocked Issue/PR is blocked on something - see comments Servicing-consider Issue for next servicing release review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants