Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert all EnC_SUPPORTED to FEATURE_ENC_SUPPORTED #91035

Closed
wants to merge 3 commits into from
Closed

Convert all EnC_SUPPORTED to FEATURE_ENC_SUPPORTED #91035

wants to merge 3 commits into from

Conversation

AaronRobinsonMSFT
Copy link
Member

No description provided.

@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 9.0.0 milestone Aug 23, 2023
@ghost
Copy link

ghost commented Aug 23, 2023

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: AaronRobinsonMSFT
Assignees: -
Labels:

area-Diagnostics-coreclr
Milestone: 9.0.0

@build-analysis build-analysis bot mentioned this pull request Aug 24, 2023
Closed
mikelle-rogers
mikelle-rogers approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@mikelle-rogers mikelle-rogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please inform me of the motivation behind this update?

@AaronRobinsonMSFT
Copy link
Member Author

Would you please inform me of the motivation behind this update?

There were two defines for EnC support, EnC_SUPPORTED and FEATURE_ENC_SUPPORTED. This PR means there is now one. I chose the style with the FEATURE_ prefix that is now the version we use as opposed to the legacy version.

@AaronRobinsonMSFT AaronRobinsonMSFT marked this pull request as ready for review August 24, 2023 15:29
@AaronRobinsonMSFT
Copy link
Member Author

This is a bit more complicated than I thought as there is some nuance here I was missing. I'm closing this PR as it is inappropriate.

@AaronRobinsonMSFT AaronRobinsonMSFT deleted the align_enc_defines branch August 24, 2023 16:47
@build-analysis build-analysis bot mentioned this pull request Aug 24, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikelle-rogers mikelle-rogers mikelle-rogers approved these changes

@hoyosjs hoyosjs hoyosjs approved these changes

Assignees

@AaronRobinsonMSFT AaronRobinsonMSFT

Labels
area-Diagnostics-coreclr
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AaronRobinsonMSFT @hoyosjs @mikelle-rogers