[main] Change OneLocBuild mirror branch to release/8.0 temporarily #90812
Conversation
carlossanlop
requested review from
jeffhandley,
ViktorHofer,
ericstj and
cristianosuzuki77
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsFixes #90755 Following the instructions to ensure we localize all the release/8.0 strings: https://github.com/dotnet/arcade/blob/main/Documentation/OneLocBuild.md#releasing-with-onelocbuild-using-arcade The first change requires changing the main mirror branch to release/8.0 temporarily. The second change is to backport this to release/8.0.
|
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/5905149537 |
|
/backport to release/8.0-rc1 |
This comment was marked as outdated.
This comment was marked as outdated.
| @@ -4,7 +4,7 @@ parameters: | |||
|
|
|||
| # Optional: A defined YAML pool - https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema?view=vsts&tabs=schema#pool | |||
| pool: '' | |||
|
|
|||
| CeapexPat: $(dn-bot-ceapex-package-r) # PAT for the loc AzDO instance https://dev.azure.com/ceapex | |||
There was a problem hiding this comment.
You cannot change things in the common folder. The contents of this folder are copied verbatim from dotnet/arcade.
| @@ -41,13 +41,12 @@ extends: | |||
| # Localization build | |||
| # | |||
|
|
|||
| # disabled due to https://github.com/dotnet/runtime/issues/90466 | |||
There was a problem hiding this comment.
Not sure if this is still broken or not. Make sure you are able to test this PR before merging. I don't think your PR validation build will test it.
There was a problem hiding this comment.
Maybe there's an azp run command to run it. Should I re-enable that in a separate PR?
There was a problem hiding this comment.
Ah nevermind, your other comment suggesting adding the parameter is precisely the lines I uncommented. It should be done in this same PR.
There was a problem hiding this comment.
This still won't run in PR validation. It only runs for official builds. Also the branch filter might be getting in the way regardless. Might be hard to test this.
|
/azp help |
This comment was marked as outdated.
This comment was marked as outdated.
|
/azp list |
|
I'll merge this and the backport and will monitor the rolling builds for any loc-related problems. |
ghost
locked as resolved and limited conversation to collaborators
Fixes #90755
Following the instructions to ensure we localize all the release/8.0 strings: https://github.com/dotnet/arcade/blob/main/Documentation/OneLocBuild.md#if-youre-releasing-from-a-branch-other-than-main-including-servicing-branches
The first change requires changing the main mirror branch to release/8.0 temporarily.
The second change is to backport this to release/8.0.