Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable BinderTracingTest.ResolutionFlow test #90801

Conversation

BruceForstall
Copy link
Member

Tracking: #90580

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 18, 2023
@ghost ghost assigned BruceForstall Aug 18, 2023
@ghost
Copy link

ghost commented Aug 18, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Tracking: #90580

Author: BruceForstall
Assignees: BruceForstall
Labels:

area-CodeGen-coreclr

Milestone: -

@BruceForstall
Copy link
Member Author

@davmason @tommcdon @dotnet/runtime-infrastructure

@BruceForstall BruceForstall added area-Tracing-coreclr and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Aug 18, 2023
@BruceForstall BruceForstall merged commit b7aea6f into dotnet:main Aug 18, 2023
@BruceForstall BruceForstall deleted the DisableBinderTracingTestResolutionFlow branch August 18, 2023 17:55
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is affecting release/8.0-rc1 too, can we please get this backported?

@BruceForstall
Copy link
Member Author

/backport to release/8.0-rc1

@github-actions
Copy link
Contributor

Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/5905756212

@BruceForstall
Copy link
Member Author

@carlossanlop I started the backport. Since this is purely related to testing, I presume no approvals are needed, and you can merge it when CI is finished?

@carlossanlop
Copy link
Member

Correct, I can approve it and merge it (tell-mode).

Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ghost ghost locked as resolved and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants