Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] Enable floats in Vector128::ExtractMostSignificantBits on arm64 and amd64 #90304

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

matouskozak
Copy link
Member

Enabling emitting intrinsics for floating element types in Vector128::ExtractMostSignificantBits on arm64 and amd64 architectures.

Arm64

The float and double types are treated as int and long types, respectively.

Amd64

No changes were needed as the current implementation introduced in #89997 already handles floating element types correctly.


Contributes to #76025.

@ghost ghost assigned matouskozak Aug 10, 2023
@matouskozak
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@fanyang-mono fanyang-mono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matouskozak
Copy link
Member Author

The failing CI lines are tracked and unrelated to this PR.

@matouskozak matouskozak merged commit 376e235 into dotnet:main Aug 11, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 10, 2023
@matouskozak matouskozak deleted the extractMSB-floats branch October 3, 2024 13:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants