-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] detect SIMD and EH support #89387
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsUse wasm-feature-detect library to detect wasm features and assert if they are missing. Fixes #84574
|
91acd42
to
487f24a
Compare
/azp run runtime-wasm |
No commit pushedDate could be found for PR 89387 in repo dotnet/runtime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: Ankit Jain <[email protected]>
/azp run runtime-wasm |
No commit pushedDate could be found for PR 89387 in repo dotnet/runtime |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
I realized that baking in the value of edit: #89433 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Use wasm-feature-detect library to detect wasm features and assert if they are missing.
Asserts with link to https://aka.ms/dotnet-wasm-features
Fixes #84574