Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LoongArch64] Fix the NotImplementedException within R2RDump. #88379

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

shushanhf
Copy link
Contributor

This PR is part of the issue #69705 to amend the LA's port.

Fix the NotImplementedException within R2RDump for LoongArch64.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-R2RDump-coreclr Ready-to-run image dump tool label Jul 4, 2023
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jul 4, 2023
@EgorBo EgorBo merged commit e5f4cc6 into dotnet:main Jul 4, 2023
@shushanhf shushanhf deleted the r2rdump_error branch July 5, 2023 00:56
@shushanhf
Copy link
Contributor Author

@EgorBo
Could you give me some advices?

The R2RDump is OK for LoongArch64.

But the crossgen2 has some problem.
For the test readytorun/tests/mainv1/mainv1.sh, after the command $CORE_ROOT/corerun $CORE_ROOT/crossgen2/crossgen2.dll --map -r:$CORE_ROOT/*.dll -r:IL_DLLS/fieldgetter.dll -r:IL_DLLS/mainv1.dll -o:test.dll ../testv1/test/test.dll

The test.dll is still PE32 format.

file ~/tests/tests8_Debug0626/readytorun/tests/mainv1/test.dll
/home/qiao/tests/tests8_Debug0626/readytorun/tests/mainv1/test.dll:        PE32 executable (DLL) (console) Mono/.Net assembly, for MS Windows

While my local runtime6.0's crossgen2 is OK for LoongArch64.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-R2RDump-coreclr Ready-to-run image dump tool community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants