[DO NOT MERGE][mono] try to interrupt Monitor.Wait #87836
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set SelfContained=true. Otherwise we get this when trying to run the app: ``` ./artifacts/bin/H elloWorld/arm64/Release/osx-arm64/publish/HelloWorld You must install or update .NET to run this application. App: /Users/alklig/work/dotnet-runtime/runtime-review/artifacts/bin/HelloWorld/arm64/Release/osx-arm64/publish/HelloWorld ```
Question: why does mono_monitor_enter_v4_internal pass allow_interruption = FALSE to mono_monitor_try_enter_loop_if_interrupted. It seems like that would prevent interruptions from interrupting anything. And yet somehow legacy mono still works. It seems like it should always get into to the retry_contended loop in the inflated monitor code and not get interrupted. Need to call WaitInfo.CheckAndResetPendingInterrupt
ghost
closed this
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try one option for fixing #87718