-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mono][ios] Add support for stripping during AOT compilation on iOS #87728
[mono][ios] Add support for stripping during AOT compilation on iOS #87728
Conversation
…ing AOT compilation on iOS
Tagging subscribers to this area: @directhex Issue DetailsThis PR adds support for stripping debug symbols and enabling IL stripping during AOT compilation of the HelloiOS sample app.
This PR should resolve the reported SOD regression.
|
@steveisok, I noticed the commented |
I think there was a problem running it on libraries, but does not appear an issue was logged. Try to enable on libraries and see what we get. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Nit:
One small thing worth considering is adding in some top level import (like AppleBuild.props
) a default value for StripDebugSymbols
like:
<StripDebugSymbols Condition="'$(StripDebugSymbols)' == ''" >false</StripDebugSymbols>
I didn't find it being set anywhere except in the Makefile of the project.
A slightly off-topic comment, but related to HelloiOS SOD regressions: There was also a regression reported with NativeAOT. However, the regression is justified, as for NativeAOT builds we were using feature switch This has been fixed in the mentioned change: 2835110#diff-41016a8344332e64360007e06a117aa072eac2efe3e0e0109ce27d5466695dccL17-L18 /cc: @SamMonoRT |
/azp run runtime-ioslike,runtime-ioslikesimulator |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run runtime-ioslike,runtime-ioslikesimulator |
Azure Pipelines successfully started running 2 pipeline(s). |
Some of the failures are reported in #73040 and shouldn't be related. |
Yeah we had problems with ActiveIssue attributes not being retained so we disabled ILStrip a while ago in #59762 I think the underlying issue could have been fixed by #87923 |
This PR adds support for stripping debug symbols and enabling IL stripping during AOT compilation of the HelloiOS sample app.
StripSymbolTable="$(StripDebugSymbols)"
to theAppleBuild.targets
file.<ShouldILStrip Condition="'$(RunAOTCompilation)' == 'true' and '$(MonoForceInterpreter)' != 'true'">true</ShouldILStrip>
to theProgram.csproj
file.This PR should resolve the reported SOD regression.