Add back fixed xunit decimal, IntPtr and UIntPtr commented test cases

[joaonunomota]

Closes #27187

These tests were removed due to an issue in xunit that is now resolved on the latest version. The test projects are also on the latest xunit version, so all that is needed is to uncomment the marked tests.

[danmoseley]

Could you look at the build errors?

[joaonunomota]

@danmoseley Sorry! Looking at those now, putting this as a draft PR until I get that fixed.

[joaonunomota]

@danmoseley The failing tests are related to Native AOT deployments. I'm not familiar with this kind of deployment, but it seems odd that it only fails with the Decimal type.

Are these tests failing expected behavior or am I missing some Native AOT deployment specific configuration?

[stephentoub]

LGTM when CI is happy

[danmoseley]

[SKIP] System.Reflection.Tests.MethodBaseTests.TestMethodBody
[FAIL] System.Reflection.Tests.InvokeRefReturnNetcoreTests.TestNullRefReturnInvoke
System.NotSupportedException : 'System.Reflection.Tests.InvokeRefReturnNetcoreTests.TestNullRefReturnInvoke[System.Decimal](System.Decimal)' is missing native code. MethodInfo.MakeGenericMethod() is not compatible with AOT compilation. Inspect and fix AOT related warnings that were generated when the app was published. For more information see https://aka.ms/nativeaot-compatibility
   at System.Reflection.Runtime.MethodInfos.RuntimeNamedMethodInfo`1.GetUncachedMethodInvoker(RuntimeTypeInfo[], MemberInfo) + 0x30
   at System.Reflection.Runtime.MethodInfos.RuntimeNamedMethodInfo`1.MakeGenericMethod(Type[]) + 0x1c4
[FAIL] System.Reflection.Tests.InvokeRefReturnNetcoreTests.TestRefReturnPropertyGetValue
System.NotSupportedException : 'System.Reflection.Tests.InvokeRefReturnNetcoreTests.TestRefReturnPropertyGetValue[System.Decimal](System.Decimal)' is missing native code. MethodInfo.MakeGenericMethod() is not compatible with AOT compilation. Inspect and fix AOT related warnings that were generated when the app was published. For more information see https://aka.ms/nativeaot-compatibility
   at System.Reflection.Runtime.MethodInfos.RuntimeNamedMethodInfo`1.GetUncachedMethodInvoker(RuntimeTypeInfo[], MemberInfo) + 0x30
   at System.Reflection.Runtime.MethodInfos.RuntimeNamedMethodInfo`1.MakeGenericMethod(Type[]) + 0x1c4
[FAIL] System.Reflection.Tests.InvokeRefReturnNetcoreTests.TestRefReturnMethodInvoke
System.NotSupportedException : 'System.Reflection.Tests.InvokeRefReturnNetcoreTests.TestRefReturnMethodInvoke[System.Decimal](System.Decimal)' is missing native code. MethodInfo.MakeGenericMethod() is not compatible with AOT compilation. Inspect and fix AOT related warnings that were generated when the app was published. For more information see https://aka.ms/nativeaot-compatibility
   at System.Reflection.Runtime.MethodInfos.RuntimeNamedMethodInfo`1.GetUncachedMethodInvoker(RuntimeTypeInfo[], MemberInfo) + 0x30
   at System.Reflection.Runtime.MethodInfos.RuntimeNamedMethodInfo`1.MakeGenericMethod(Type[]) + 0x1c4
[SKIP] System.Tests.ExceptionTests.ThrowStatementDoesNotResetExceptionStackLineOtherMethod

[danmoseley]

I pushed a change that will likely fix it, but I didn't attempt to test. we'll see.

[ghost]

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Closes #27187

These tests were removed due to an issue in xunit that is now resolved on the latest version. The test projects are also on the latest xunit version, so all that is needed is to uncomment the marked tests.

Author:	joaonunomota
Assignees:	-
Labels:	area-Meta, community-contribution, needs-area-label
Milestone:	-

[danmoseley]

@joaonunomota I should be able to merge tomorrow. Thanks for your first contribution! Are you interested in another? We have quite a few issues marked "help wanted" and also a fair number marked "api-approved" that would be adding a new API to .NET. You are welcome to grab any not already assigned.

[joaonunomota]

@danmoseley Thank you for all the help! I'll have a look through those other issues

[danmoseley]

@dotnet/dnceng a variety of flavors ran over 4 hours here and timed out. this is the 2nd time around. is there a known issue -- does this mean low capacity, or slow machines?

[missymessa]

@dotnet/dnceng a variety of flavors ran over 4 hours here and timed out. this is the 2nd time around. is there a known issue -- does this mean low capacity, or slow machines?

Yes: dotnet/arcade#13774

[danmoseley]

Unrelated

System.Threading.Tasks.Dataflow.Tests (parallel test collections = on, max threads = 6)
Process terminated. Assertion failed.
m_stateObject must only be for ExecutionContext but contained .
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.get_Context() in /_/src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncTaskMethodBuilderT.cs:line 336
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.MoveNext(Thread threadPoolThread) in /_/src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncTaskMethodBuilderT.cs:line 376
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.MoveNext() in /_/src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncTaskMethodBuilderT.cs:line 344
   at System.Threading.ThreadPool.<>c.<.cctor>b__53_0(Object state) in /_/src/libraries/System.Private.CoreLib/src/System/Threading/ThreadPoolWorkQueue.cs:line 1367
   at System.Threading.Tasks.Sources.ManualResetValueTaskSourceCore`1.SignalCompletion() in /_/src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/Sources/ManualResetValueTaskSourceCore.cs:line 235
   at System.Threading.Tasks.Sources.ManualResetValueTaskSourceCore`1.SetResult(TResult result) in /_/src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/Sources/ManualResetValueTaskSourceCore.cs:line 68
   at System.Threading.Tasks.Dataflow.Tests.AsyncEnumerable.Repeat(Int32 item, Int32 count)+MoveNext() in /_/src/libraries/System.Threading.Tasks.Dataflow/tests/Dataflow/DataflowTestHelper.IAsyncEnumerable.cs:line 22
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.ExecutionContextCallback(Object s) in /_/src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncTaskMethodBuilderT.cs:line 286
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state) in /_/src/libraries/System.Private.CoreLib/src/System/Threading/ExecutionContext.cs:line 270
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.MoveNext(Thread threadPoolThread) in /_/src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncTaskMethodBuilderT.cs:line 370
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.ExecuteFromThreadPool(Thread threadPoolThread) in /_/src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncTaskMethodBuilderT.cs:line 341
   at System.Threading.ThreadPoolWorkQueue.Dispatch() in /_/src/libraries/System.Private.CoreLib/src/System/Threading/ThreadPoolWorkQueue.cs:line 919
   at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart() in /_/src/libraries/System.Private.CoreLib/src/System/Threading/PortableThreadPool.WorkerThread.NonBrowser.cs:line 58
   at System.Threading.Thread.StartCallback() in /_/src/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs:line 105
./RunTests.sh: line 168: 95931 Abort trap: 6           

[danmoseley]

@stephentoub Any thoughts about above stack?

[stephentoub]

Any thoughts about above stack?

Seems like there's a race condition that may have happened during the assert; the assert is checking for null and then checking for something else, and it looks most likely that the value changed to null just after it was checked for null, and thus failed. The assert is easily fixable. I'm more concerned about in what situation there could be a race condition here... it's not immediately obvious.

[danmoseley]

Thanks. I'll not open an issue since it's not actionable -- with your assert, it will be next time.