Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added IReadOnlyDictionary to HttpRequestOptions #86983

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Added IReadOnlyDictionary to HttpRequestOptions #86983

merged 3 commits into from
Jun 21, 2023

Conversation

xrem
Copy link
Contributor

@xrem xrem commented May 31, 2023

Closes #68149

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label May 31, 2023
@ghost
Copy link

ghost commented May 31, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #68149

Author: xrem
Assignees: -
Labels:

area-System.Net.Http
Milestone: -

@xrem
Copy link
Contributor Author

xrem commented May 31, 2023

@dotnet-policy-service agree

@xrem
Copy link
Contributor Author

xrem commented Jun 1, 2023 •
edited
Loading

How do I generate CombatibilitySupression.xml for System.Net.Http? 🤔

Running dotnet build ApiCompat.proj /p:ApiCompatGenerateSuppressionFile=true inside src\libraries\apicompat as task output says, does not produce supression for related changes.

https://dev.azure.com/dnceng-public/public/_build/results?buildId=291697&view=logs&j=4590e2f8-699e-5f49-61ce-34aa015d5222&t=9a53ce37-8f72-55d0-fdf3-f3f4cb573bd0&l=2147

This was referenced Jun 1, 2023
Closed
Open
@xrem xrem force-pushed the xrem/http-request-options-readonly-dictionary branch from 3c67669 to f9b3953 Compare June 1, 2023 18:53
@xrem xrem marked this pull request as ready for review June 1, 2023 20:59
@xrem xrem requested a review from stephentoub June 1, 2023 20:59
@xrem
Copy link
Contributor Author

xrem commented Jun 1, 2023

Looks like failed checks should pass, but I don't know how to dispatch them to run again :)

This was referenced Jun 1, 2023
Closed
Closed
stephentoub
stephentoub reviewed Jun 2, 2023
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Can you add tests, too?

@xrem
Copy link
Contributor Author

xrem commented Jun 2, 2023 •
edited
Loading

My tests passed, but there is still some issues with infrastructure like this:
image
Log

So, it's ready to review.

@xrem xrem requested a review from stephentoub June 2, 2023 18:31
@xrem xrem requested a review from stephentoub June 6, 2023 06:30
stephentoub
stephentoub approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@stephentoub stephentoub requested a review from a team June 8, 2023 15:40
@rzikm
Copy link
Member

rzikm commented Jun 20, 2023

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

rzikm
rzikm approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@rzikm rzikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lets wait for the CI and then we're good to merge

@rzikm
Copy link
Member

rzikm commented Jun 21, 2023 •
edited
Loading

CI Failure is unrelated. We're good to go. Thank you for the contribution!

@rzikm rzikm merged commit 19a088e into dotnet:main Jun 21, 2023
@xrem xrem deleted the xrem/http-request-options-readonly-dictionary branch June 22, 2023 08:24
@karelz karelz added this to the 8.0.0 milestone Jul 3, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rzikm rzikm rzikm approved these changes

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
area-System.Net.Http community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

[API Proposal]: HttpRequestOptions should implement IReadOnlyDictionary
4 participants
@xrem @rzikm @stephentoub @karelz