Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NativeAOT] Handle event pipe environment variable configuration and output to file #86656

Merged
merged 7 commits into from
May 25, 2023

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented May 23, 2023

Updates to NativeAOT event pipe:

  • Respect environment variable configuration
  • Handle writing out to a file
  • Enable tracing/eventpipe/config/name_config_with_pid test, which uses environment variable configuration to write directly to a file.

Also some tweaks to headers to reduce some of the assumptions they have about what is/isn't included already.

@ghost
Copy link

ghost commented May 23, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Updates to NativeAOT event pipe:

  • Respect environment variable configuration
  • Handle writing out to a file for Windows - the TODO remains for non-Windows
  • Enable tracing/eventpipe/config/name_config_with_pid test, which uses environment variable configuration to write directly to a file.

Also some tweaks to headers to reduce some of the assumptions they have about what is/isn't included already.

Author: elinor-fung
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: -

@elinor-fung elinor-fung changed the title [NativeAOT] Handle event pipe environment variable configuration and output to file on Windows [NativeAOT] Handle event pipe environment variable configuration and output to file May 24, 2023
@elinor-fung
Copy link
Member Author

Verified that the newly enabled test is running/passing in CI.
name_config_with_pid result: log
PayloadGroup0 now has three tracing tests enabled: log

Copy link
Contributor

@LakshanF LakshanF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding both environment variable and file support on all platforms!

@elinor-fung elinor-fung merged commit 12a7bda into dotnet:main May 25, 2023
@elinor-fung elinor-fung deleted the nativeaot-eventpipe-config branch May 25, 2023 19:40
@ghost ghost locked as resolved and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants