Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[interp] Remove char element type support from transform-simd #86534

Merged
merged 1 commit into from
May 20, 2023

Conversation

kg
Copy link
Member

@kg kg commented May 19, 2023

In the comments for #86475 @tannergooding caught a mistake I introduced - we don't support vectors of char, so the interp intrinsics shouldn't handle them.

This PR reverses the cases I added, and also disables some of the more exotic types for packedsimd.

Also disable unusual types for packedsimd
@ghost
Copy link

ghost commented May 19, 2023

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

In the comments for #86475 @tannergooding caught a mistake I introduced - we don't support vectors of char, so the interp intrinsics shouldn't handle them.

This PR reverses the cases I added, and also disables some of the more exotic types for packedsimd.

Author: kg
Assignees: -
Labels:

area-Codegen-Interpreter-mono

Milestone: -

@kg kg merged commit 39ba238 into dotnet:main May 20, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants