[LoongArch64] Fix some bugs in the test sets 'System.Runtime.Tests' and 'System.Linq.Expressions.Tests' for loongarch64. #86435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue Details
|
|
Based on this commit, the libraries test sets "System.Runtime.Tests" and "System.Linq.Expressions.Tests" has been all passed on loongarch64. ----- start 2023年 05月 18日 星期四 20:13:42 CST =============== To repro directly: =====================================================
pushd ./libs-testcase-release-v8.0.0-preview.4.23259.5/System.Runtime.Tests/Release/net8.0-unix
/home/xuliangyu/libs-8-tests/net8.0-linux-Release-LA64-v8.0.0-preview.4.23259.5/dotnet exec --runtimeconfig System.Runtime.Tests.runtimeconfig.json --depsfile System.Runtime.Tests.deps.json xunit.console.dll System.Runtime.Tests.dll -xml testResults.xml -nologo -notrait category=AdditionalTimezoneChecks -notrait category=OuterLoop -notrait category=failing
popd
===========================================================================================================
~/libs-8-tests/libs-testcase-release-v8.0.0-preview.4.23259.5/System.Runtime.Tests/Release/net8.0-unix ~/libs-8-tests
Discovering: System.Runtime.Tests (method display = ClassAndMethod, method display options = None)
Discovered: System.Runtime.Tests (found 9163 of 9210 test cases)
Starting: System.Runtime.Tests (parallel test collections = on, max threads = 4)
System.Tests.DateTimeOffsetTests.ToLocalTime_MinValue [SKIP]
Condition(s) not met: "IsMinValueNegativeLocalOffset"
System.Tests.StringTests.IndexOf_SingleLetter(s: "Hello", target: '\0', startIndex: 0, count: 5, expected: -1) [SKIP]
Target \0 is not supported in ICU
System.Tests.DateTimeOffsetTests.ToLocalTime_Ambiguous [SKIP]
Condition(s) not met: "IsPacificTime"
System.Tests.StringTests.LastIndexOf_NullInStrings [SKIP]
Condition(s) not met: "IsNlsGlobalization"
System.Tests.StringTests.IndexOf_NullInStrings [SKIP]
Condition(s) not met: "IsNlsGlobalization"
System.Tests.StringTests.EndsWith_NullInStrings_NonOrdinal [SKIP]
Condition(s) not met: "IsNlsGlobalization"
System.Tests.StringTests.StartsWith_NullInStrings_NonOrdinal [SKIP]
Condition(s) not met: "IsNlsGlobalization"
System.Tests.StringTests.EndsWith_NullInStrings [SKIP]
Condition(s) not met: "IsNlsGlobalization"
System.Tests.StringTests.StartsWith_NullInStrings [SKIP]
Condition(s) not met: "IsNlsGlobalization"
System.Tests.ArgIteratorTests.ArgIterator_GetNextArgType [SKIP]
Condition(s) not met: "IsArgIteratorSupported"
System.Tests.ArgIteratorTests.ArgIterator_GetRemainingCount_GetNextArg [SKIP]
Condition(s) not met: "IsArgIteratorSupported"
System.Tests.TimeZoneInfoTests.UnsupportedImplicitConversionTest [SKIP]
Condition(s) not met: "DoesNotSupportIanaNamesConversion"
System.Runtime.Tests.JitInfoTests.JitInfoIsNotPopulated [SKIP]
Condition(s) not met: "IsMonoAOT"
Finished: System.Runtime.Tests
=== TEST EXECUTION SUMMARY ===
System.Runtime.Tests Total: 58145, Errors: 0, Failed: 0, Skipped: 13, Time: 42.250s
~/libs-8-tests
----- end 2023年 05月 18日 星期四 20:14:28 CST ----- exit code 0 ----------------------------------------------------------
exit code 0 means Exited Successfully
2023年 05月 22日 星期一 10:20:18 CST Testing: @@@@@ home/xuliangyu/libs-8-tests/libs-testcase-release-v8.0.0-preview.4.23259.5/System.Linq.Expressions.Tests/Release/net8.0 @@@@@ Discovering: System.Linq.Expressions.Tests (method display = ClassAndMethod, method display options = None) Discovered: System.Linq.Expressions.Tests (found 5665 of 5672 test cases) Starting: System.Linq.Expressions.Tests (parallel test collections = on, max threads = 4) Finished: System.Linq.Expressions.Tests === TEST EXECUTION SUMMARY === System.Linq.Expressions.Tests Total: 35113, Errors: 0, Failed: 0, Skipped: 0, Time: 47.403s |
…to UINT32/UINT64. * fix some random failed testcases in System.Runtime.Tests.
shushanhf
approved these changes
May 19, 2023
Fix the RangeCheck bug of the TYP_INT case in CodeGen::genRangeCheck().
LuckyXu-HF
changed the title
|
Hi, @jakobbotsch |
LuckyXu-HF
changed the title
jakobbotsch
approved these changes
May 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the issue #69705 to amend the LA's port.
Fix some bugs in the test sets 'System.Runtime.Tests' and 'System.Linq.Expressions.Tests' for loongarch64：
fix the error of the Truncate/Saturate convert from Float/Double NAN to UINT32/UINTPTR.
fix some random failed testcases in System.Runtime.Tests.
fix the RangeCheck bug of the TYP_INT case in CodeGen::genRangeCheck().